From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C948B6ECE3; Wed, 15 Jun 2022 12:29:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C948B6ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1655285394; bh=FjlfGUdiSMht0C7EWgnuCwf9sSU0S/o2LyXC4ZllHF4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZzQUBIpUU5rr59GndZWSZTuVHtFtkmOae93E1kQgM0zKOkmay7UPLbVi+N9AUzwEv waqw6d69+2RNfl25aIs8v5wkLlwumGUvzIkxc4oaKPNrY50WdDij+AvBtXlSnQ/E11 vxgB84RwsO6tgSnNJgOSAOVTe8R4nfx/vUg6RZ7Q= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 93AC26ECE3 for ; Wed, 15 Jun 2022 12:29:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 93AC26ECE3 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1o1PLT-0000kS-Q2; Wed, 15 Jun 2022 12:29:52 +0300 Date: Wed, 15 Jun 2022 12:27:34 +0300 To: Igor Munkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD97D44297578DBEB86CC0506E018D2C7F54E241DB180169FE4182A05F538085040365EAC742C75168087041872D44254359B17A1A489199167FFBE4FC00E7D6D6C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73230F712CF4B3924EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375189E43B47FB350A8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8185A9112F8A1E085A62F4C08573801F6117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAA867293B0326636D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B65D56369A3576CBA5089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218C6CDE5D1141D2B1C06C719BCF33A42AA941C757B377D9774297B6D4AAC25BDFFAD91A466A1DEF99B296C473AB1E14218B936CB490224F2464EEA7BD89490CAC0EDDA962BC3F61961 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AA8975497C7004E8F8053870821BBC990C4C07D76DACD47019B74B7B9C9833EF0F6304CF4DA63EA11D7E09C32AA3244C4DAD18CBB44DD9CD4E78F6AE2804207E97FE24653F78E668FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojF9WnY+1VDr4Z3i8ICSoDfw== X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284EF3A225B9C1D55455B5ACDEA1B01850CE0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [v2][PATCH 5/5] ci: add job with build using Ninja on linux-x86_64 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, after fixes mentioned by Igor below and my 2 cents below. On 15.06.22, Igor Munkin via Tarantool-patches wrote: > Sergey, > > Thanks for the patch! LGTM as trivial, but please consider nits below. > > On 06.06.22, Sergey Bronnikov wrote: > > --- > > .github/workflows/linux-x86_64-ninja.yml | 51 ++++++++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > create mode 100644 .github/workflows/linux-x86_64-ninja.yml > > > > diff --git a/.github/workflows/linux-x86_64-ninja.yml b/.github/workflows/linux-x86_64-ninja.yml > > new file mode 100644 > > index 00000000..833d36d9 > > --- /dev/null > > +++ b/.github/workflows/linux-x86_64-ninja.yml > > @@ -0,0 +1,51 @@ > > +name: "LuaJIT test workflow with Ninja (Linux/x86_64)" > > + > > +on: > > + push: > > + branches-ignore: > > + - '**-notest' > > + - 'upstream-**' > > + tags-ignore: > > + - '**' > > + > > +concurrency: > > + # An update of a developer branch cancels the previously > > + # scheduled workflow run for this branch. However, the default > > + # branch, and long-term branch (tarantool-1.10, tarantool-2.8, > > + # etc.) workflow runs are never canceled. > > + # > > + # We use a trick here: define the concurrency group as 'workflow > > + # run ID' + # 'workflow run attempt' because it is a unique > > + # combination for any run. So it effectively discards grouping. > > + # > > + # XXX: we cannot use `github.sha` as a unique identifier because > > + # pushing a tag may cancel a run that works on a branch push > > + # event. > > + group: ${{ ( > > + github.ref == 'refs/heads/tarantool' || > > + startsWith(github.ref, 'refs/heads/tarantool-')) && > > + format('{0}-{1}', github.run_id, github.run_attempt) || > > + format('{0}-{1}', github.workflow, github.ref) }} > > + cancel-in-progress: true > > + > > +jobs: > > + test-linux-x86_64: Nit: May be `test-linux-ninja-x86_64` is better? To be different from the same name for make target building? > > + runs-on: ubuntu-20.04-self-hosted > > + strategy: > > + fail-fast: false Nit: As far as there is no testing matrix we can omit strategy for it. > > + name: Linux/x86_64 ${{ matrix.BUILDTYPE }} > > There is no testing matrix, so you can just name the workflow kinda > "Linux/x86_64 Ninja". > > > + steps: > > + - uses: actions/checkout@v2.3.4 > > + with: > > + fetch-depth: 0 > > + submodules: recursive > > + - name: setup > > + run: | > > + sudo apt -y update > > + sudo apt -y install cmake ninja-build gcc perl > > + - name: configure > > + run: cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -G Ninja > > + - name: build > > + run: cmake --build . -j $(nproc) > > + - name: test > > + run: cmake --build . -j $(nproc) -t test > > Please, use long options, as we discussed here[1]. > > > -- > > 2.25.1 > > > > [1]: https://lists.tarantool.org/tarantool-patches/YpjeijSClWO0v82Y@tarantool.org/ > > -- > Best regards, > IM -- Best regards, Sergey Kaplun