From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BB70C6ECE3; Wed, 15 Jun 2022 12:22:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BB70C6ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1655284935; bh=J0CGrky2di2ogf4r0DRyNNZZqfB6X0/v7R7IHvQN2i8=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=MoNeCQs0CqXWo53B4DkxanaekmtLsP8rO5eCHIckSIHqHOaIPtEViCRzbYojgsLtD mTmLqoZEOyYOPpRq15nXPhY5sJxr/q47r8Rqg7zNl3VlAzRsnJjr96Cbx50kxtDtOh PreBYG/1DyTmjzqzhD7qF4QpmDwrxsj4LyIlIT8w= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 00D976ECE3 for ; Wed, 15 Jun 2022 12:22:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 00D976ECE3 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1o1PE5-0001la-9j; Wed, 15 Jun 2022 12:22:13 +0300 Date: Wed, 15 Jun 2022 12:19:56 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD97D44297578DBEB86B62F79C7FEB21477876C1A6C9E05F4E9182A05F538085040C98DAAC0547FD27779B63DF57510C06233DC399B867E59527F657A46FEB9B615 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE704BA85F3D5A9F85BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AD1E1BF10F09609D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D815214EAA06D4F17DFAD665F6DCB6D40C117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF80095D1E57F4578A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18BDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B65D56369A3576CBA5089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218C6CDE5D1141D2B1C6DC33AA1D2179FEDBC40329AE74ADBAA0966138E528065BCAD91A466A1DEF99B296C473AB1E14218B936CB490224F2464EEA7BD89490CAC0EDDA962BC3F61961 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D1AE09A115117C960A14EB86941E7BC204D8E91099A696A1129010800ABC6D5621BAEC0D309294B81D7E09C32AA3244C4D9147C06E9EC7D05D5937618D41E0821E098CBE561D6343729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojF9WnY+1VDr5KyvDi43rYKQ== X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284ED5D6B52552D075FEA3441D76D175D2DB0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [v2][PATCH 4/5] build/ninja: create file lists outside of cmake commands X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except a few nits regarding the commit message. On 02.06.22, Sergey Bronnikov via Tarantool-patches wrote: > Patch adds a last change required for building LuaJIT with Ninja - using Typo: s/Patch/The patch/ > glob inside CMake commands (add_custom_command and > set_source_files_properties) breaks buildng with Ninja. Typo: s/buildng/building/ > > By default CMake generates files suitable for building a project with > Make. However, it allows to generate files for Ninja too. Ninja [1] may > build project a bit faster than Make, see comparison in [2]. Typo: s/comparison/the comparison/ > > How-to build with Ninja: > > $ cmake -G Ninja -B build -S . > $ cmake --build build --parallel Side note: Unfortunately `make test` command (or what should I use for tests, when build with ninja?) fails with the following error: | Checking /home/burii/reviews/luajit/ninja/build/src/jit/vmdef.lua 3 warnings | | /home/burii/reviews/luajit/ninja/build/src/jit/vmdef.lua:5:121: (W631) line is too long (595 > 120) | /home/burii/reviews/luajit/ninja/build/src/jit/vmdef.lua:7:121: (W631) line is too long (613 > 120) | /home/burii/reviews/luajit/ninja/build/src/jit/vmdef.lua:11:121: (W631) line is too long (273 > 120) But this is the problem of OOS build (default for ninja), not this patch, IINM. > > 1. https://ninja-build.org/ > 2. https://mesonbuild.com/Simple-comparison.html > --- > src/host/CMakeLists.txt | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/host/CMakeLists.txt b/src/host/CMakeLists.txt > index e01db87d..1ce3e224 100644 > --- a/src/host/CMakeLists.txt > +++ b/src/host/CMakeLists.txt > -- > 2.25.1 > -- Best regards, Sergey Kaplun