From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 295D66ECE3; Wed, 15 Jun 2022 11:55:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 295D66ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1655283308; bh=fa52Sa6iaj5nlgxElWDaXfKpZbU/O1IlX6K8D6WCBLc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Wr+rwhZEmShWHz78fzeafeT14sOnyg7rNUGaiU4IlnUWGrM50CNMLqtsZcJ2L4zlZ BQSYQQx+klsnN+B+m0uRvYitSFUS8d4HzxitQcWmG+WTbpPsvJPnWNlkUp/qKHgmce Grts8y7MJ0a70GapnV5HXP6Cqed5gV7DaGvCt0g8= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4665E6ECE3 for ; Wed, 15 Jun 2022 11:55:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4665E6ECE3 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1o1Onp-0004Lx-Bi; Wed, 15 Jun 2022 11:55:05 +0300 Date: Wed, 15 Jun 2022 11:47:59 +0300 To: Sergey Bronnikov Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD97D44297578DBEB86157A728CB9AF912FB29B9D39C83553BE182A05F53808504028A12BD64848C36BD8D0E00DBBF548049440F166CD42EAFFD3917B8CB6DAA3C9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B9FBA884A7C9B8BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D70459434292EC88638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F2AFB1E0399053BE030B1CFA14A68642117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18C26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B67ECBC18655D52CDF089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218C6CDE5D1141D2B1CE88C94408D4A2CAB19C5A6C4EE9A7DE62AA609913712E492AD91A466A1DEF99B296C473AB1E14218B936CB490224F2464EEA7BD89490CAC0EDDA962BC3F61961 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343536C6A4332D8B8A5E909B3D9E8AE286ED73FADA30A240DF942637214B0199C76CC83BA45ADDF5BA1D7E09C32AA3244C988C58D017B910C157EC60EA6E8EC9E239C99C45E8D137E9927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojF9WnY+1VDr6mpz07VfiakA== X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284EE7B798B2AC7B54582B4885AAFF253F88A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [v2][PATCH 0/5] Support building with Ninja X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the series! I've left some nits for 4th and 5th patches in the relevant threads. Everything related to the first three patches you can find below. Thanks for the series! You can find my comments in the relevant patches. However, I have one more: since we're going to use Ninja, please add Ninja-specific output to .gitignore to not spoil output. I tried to find more elegant solution for this case, but failed. Look like we definitely have no option other than define all target names conditionally. The related patches look good, but I propose some minor changes: * Please merge the first three patches into one, since they all related to the same fix: provide unique names for targets building both LuaJIT library and binary. * LUAJIT_DEPS looks irrelevant if LUAJIT_BIN is introduced: the original purpose of this variable was to template the dependency of target. * Please adjust install components, since you've changed the default target name to The last general nits: * We don't use complex prefixes for commit subjects (like 'build/ninja'), so please use just 'build', since Ninja specifics are mentioned in the commit message. * Since we're going to use Ninja, please add Ninja-specific output to .gitignore to not spoil output. On 02.06.22, Sergey Bronnikov wrote: > Patch series support of Ninja to a LuaJIT build system and a new job to > continuous integration pipeline that builds using Ninja. > > On my laptop Ninja reduces building time by 14% (with Make it takes 5.7 > sec, with Ninja 3.9 sec). It is not so much, but without Ninja support > in LuaJIT it is not possible to build Tarantool with Ninja. > > Branch: https://github.com/tarantool/luajit/tree/ligurio/ninja-support > CI status: https://github.com/tarantool/luajit/commit/acfd7552f1b8428242a6b8cbc783ed584c21beef > > Sergey Bronnikov (5): > build/ninja: refactoring > build/ninja: create target with cli binary only once > build/ninja: rename default target > build/ninja: create file lists outside of cmake commands > ci: add job with build using Ninja on linux-x86_64 > > .github/workflows/linux-x86_64-ninja.yml | 51 ++++++++++++++++++++++++ > src/CMakeLists.txt | 46 ++++++++------------- > src/host/CMakeLists.txt | 6 ++- > 3 files changed, 72 insertions(+), 31 deletions(-) > create mode 100644 .github/workflows/linux-x86_64-ninja.yml > > -- > 2.25.1 > -- Best regards, IM