From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 050026ECE6; Mon, 6 Jun 2022 13:25:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 050026ECE6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1654511156; bh=ArartoHKFJ3SuJBvsaO8wsHxUmqmgLBTvZVUjyCio6o=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Weh6xgNL70987wF+mj5+uHFJWoArmXM0dOFD2r2DCC4Y80QGH6n6BaohbZld/Iv6s Y5uPWxrNlzIzSsKfapJprR2qppMNKhSI5a+rjjPJ0Bl93sr1Clk7FcJG9T2Y7Ylw9v Fls7hB+ZQnU+aoC9D+52KPfAFzw615p+HA9dK4lg= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D4B3C6ECE6 for ; Mon, 6 Jun 2022 13:25:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D4B3C6ECE6 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1ny9vk-0008Qn-Mg; Mon, 06 Jun 2022 13:25:53 +0300 Date: Mon, 6 Jun 2022 13:18:48 +0300 To: Sergey Bronnikov Message-ID: References: <8826142ef8ae2e352728e3b4fdf5390851fe2e25.1654098694.git.imun@tarantool.org> <58ae0b0e-387a-2171-1d3b-dbdfa746c421@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9A866A199C4CD7E1088914E93578825C95B65CC7335E7B75F182A05F538085040FB6F32048638BE606163A5CB548DD8AEF1FFD029B734C216CF208F92756E7A5B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BCC85671EC7A750CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063727BBC20C3D5F36038638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D86BA4D5CEECB274FE61D462C7C97FC7A2117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6D635BA3ABDB36C18089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A529DEF4528E1832EA27FC22B84499A4B6A51CD1EBAF773589D59269BC5F550898D99A6476B3ADF6B4886A5961035A09600383DAD389E261318FB05168BE4CE3AF X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3473457D764E1CDE77995CB5DD5B24C1432B5FB225AA12EDC627F79979BE18662CD6CC78A98F14D5161D7E09C32AA3244CBC96A9FF5B8A49E16A4B04672404F49A7C0C08F7987826B9927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojw5CbW4eaNzKkCvwLbuOjbQ== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D65C968BBA49336719A26C895006AD0AABA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ci: make GitHub workflows more CMake-ish X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! On 03.06.22, Sergey Bronnikov wrote: > Thanks for changes! > > LGTM now with one note - seems passing "--parallel" for target Added your tag: | Reviewed-by: Sergey Bronnikov > "LuaJIT-luacheck" is useless because: > > 1. luacheck requires LuaLanes for enabling multithreading and it is not > installed in LuaJIT CI > > 2. option "--jobs" is not passed for luacheck in test/CMakeLists.txt > > Feel free to keep patch as is, we can enable option "--jobs" and install > required LuaLanes module later > > in a separate patch. I've removed "-j" for LuaJIT-luacheck. Diff is below: ================================================================================ diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 3091c10b..e2d353e9 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -45,4 +45,4 @@ jobs: - name: configure run: cmake . - name: test - run: cmake --build . --parallel $(($(nproc) + 1) --target LuaJIT-luacheck + run: cmake --build . --target LuaJIT-luacheck ================================================================================ > > Sergey > -- Best regards, IM