From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <max.kokryashkin@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] sysprof: add `LUAJIT_DISABLE_SYSPROF` to Makefile
Date: Wed, 18 May 2022 13:58:47 +0300 [thread overview]
Message-ID: <YoTRZ3+yBlL0w70a@tarantool.org> (raw)
In-Reply-To: <20220511082521.389687-1-m.kokryashkin@tarantool.org>
Max,
Thanks for the patch! LGTM as trivial.
On 11.05.22, Maxim Kokryashkin wrote:
> The Makefile.original was not properly updated for sysporf. This
> patch fixes this issue by adding the `LUAJIT_DISABLE_SYSPROF`
> option to it.
>
> Part of tarantool/tarantool#781
> ---
> Branch: https://github.com/tarantool/luajit/tree/fckxorg/sysprof-rc-full-ci
>
> src/Makefile.original | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/Makefile.original b/src/Makefile.original
> index 50b84bfe..dd1c6a76 100644
> --- a/src/Makefile.original
> +++ b/src/Makefile.original
> @@ -116,6 +116,8 @@ XCFLAGS=
> # Disable the memory profiler.
> #XCFLAGS+= -DLUAJIT_DISABLE_MEMPROF
> #
> +# Disable the system profiler.
> +#XCFLAGS+= -DLUAJIT_DISABLE_SYSPROF
> ##############################################################################
>
> ##############################################################################
> --
> 2.35.1
>
--
Best regards,
IM
next prev parent reply other threads:[~2022-05-18 11:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 8:25 Maxim Kokryashkin via Tarantool-patches
2022-05-11 8:25 ` [Tarantool-patches] [PATCH] sysprof: change C configuration API Maxim Kokryashkin via Tarantool-patches
2022-05-18 14:20 ` Igor Munkin via Tarantool-patches
2022-05-19 6:56 ` Sergey Kaplun via Tarantool-patches
2022-05-11 8:25 ` [Tarantool-patches] [PATCH] sysprof: enrich symtab on a new trace or a proto Maxim Kokryashkin via Tarantool-patches
2022-05-19 14:07 ` Sergey Kaplun via Tarantool-patches
2022-05-11 8:25 ` [Tarantool-patches] [PATCH] sysprof: fix `SYSPROF_HANDLER_STACK_DEPTH` Maxim Kokryashkin via Tarantool-patches
2022-05-18 11:06 ` Igor Munkin via Tarantool-patches
2022-05-19 5:23 ` Sergey Kaplun via Tarantool-patches
2022-05-26 16:28 ` Igor Munkin via Tarantool-patches
2022-05-11 8:25 ` [Tarantool-patches] [PATCH] sysprof: make sysprof internal API funcs static Maxim Kokryashkin via Tarantool-patches
2022-05-18 9:49 ` Sergey Kaplun via Tarantool-patches
2022-05-18 11:01 ` Igor Munkin via Tarantool-patches
2022-05-26 16:28 ` Igor Munkin via Tarantool-patches
2022-05-18 10:01 ` [Tarantool-patches] [PATCH] sysprof: add `LUAJIT_DISABLE_SYSPROF` to Makefile Sergey Kaplun via Tarantool-patches
2022-05-18 10:58 ` Igor Munkin via Tarantool-patches [this message]
2022-05-26 16:25 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoTRZ3+yBlL0w70a@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH] sysprof: add `LUAJIT_DISABLE_SYSPROF` to Makefile' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox