From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2FAAA6EFDA; Thu, 26 May 2022 19:28:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2FAAA6EFDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1653582510; bh=jmzkQed2CMG3yn8kBW9st0QHFxO5W4E84PHbe9L1uss=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=d0Ee6LwhXbQZ1Uzw9ZVQ7wY4kU1+wAMeNC+EYY2gx5P0d1kFOpGy/x9tfdH6C76aA ostoUhpn4XgDXtD6GKqNJ046yhq0Yt55KUzCztiGyAWoVA4bmxio5/5fesCZqpqhB9 ylHSi4Eit/4Y//QuZZq9P1kNAlPuYSHNCJ2nBcNU= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 612E16EFDA for ; Thu, 26 May 2022 19:28:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 612E16EFDA Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1nuGLb-0001sb-6e; Thu, 26 May 2022 19:28:27 +0300 Date: Thu, 26 May 2022 19:21:25 +0300 To: Sergey Bronnikov Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD959DE7DA6C9DEA5D58C6AEA7465E4D452926B3B0DAAA3D0B4182A05F538085040F930FE323307608F108E6D49B7B17647A584B6CBF0815C149071B9CD4F031910 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74C265300876DF183C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE721D130CF676D2164EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BEBC5CAB6D411FFA6482417F3697D1CF0824C980103FCF8D1CC7F00164DA146DAFE8445B8C89999728AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8D2DCF9CF1F528DBCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B53A69B3AC30C7B9475ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A5590127AC5F97AB2D3B5BE42C5A6609CE4ACBA21357EFBE9FD59269BC5F550898D99A6476B3ADF6B4886A5961035A09600383DAD389E261318FB05168BE4CE3AF X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A246DFF68F0EE19E2FB70AE709ED8CC23D650DF035F9159A807A173836E92EDCE345B53BCEF07D121D7E09C32AA3244CD71FCEC93CE8A41650AAD1F8C76891EAA995755A1445935E83B48618A63566E0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojXnflq/26yj0JgmOuuLdHWA== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D66561AF8A29012BC8E03158EC0D99DDBDA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] build: support build using Ninja X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! I only dump our offline discussion: * We decided to add a separate CI pipeline to prevent ninja build to be broken again. It will be run on Linux/x86_64 with no CMake specification at all (i.e. -DLUAJIT_ENABLE_GC64=OFF and -DCMAKE_BUILD_TYPE=Release). * We decided to refactor the targets related to LuaJIT executable, since ninja forbids using different targets building the same name. Hence instead of using parameterized dependencies of the fixed targets, let's use parameterized targets with fixed dependencies (hope it's not too tricky wording for you). On 23.05.22, Sergey Bronnikov wrote: > By default CMake generates files suitable for building a project with > Make. However, it allows to generate files for Ninja too. Ninja [1] may > build project a bit faster than Make, see [2]. Patch adds changes > required for building with Ninja. Minor: Please, describe these changes in detail. > > How-to build wit Ninja: Typo: s/wit/with/. > > $ cmake -G Ninja -B build -S . > $ ninja -C build luajit > > On my laptop Ninja reduces building time by 14% (with Make it takes 5.7 > sec, with Ninja 3.9 sec). It is not so much, but without Ninja support in > LuaJIT it is not possible to build Tarantool with Ninja. Minor: This rationale can be moved below (after ---), since I see no reason to mention particular results in the commit message. The links below are more than enough. > > 1. https://ninja-build.org/ > 2. https://mesonbuild.com/Simple-comparison.html > --- > src/CMakeLists.txt | 4 ++-- > src/host/CMakeLists.txt | 6 ++++-- > 2 files changed, 6 insertions(+), 4 deletions(-) > > -- > 2.25.1 > -- Best regards, IM