From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id AFD756EFDA; Wed, 4 May 2022 16:09:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AFD756EFDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1651669781; bh=x2mCoQPFYKetwksq10SR+oZdODSrJ8eN1ITKkudr+Lk=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=eW6A6uYNvQRLfjBTABhJK1ZD3+dkM3KkhRrttU8et/sygPsb22K0f/e/BRt1Ftcxo Yjma9Gp4Y2JltkvIdDY26cu0bd53KJTnAcMzazFhYv5NonE6yXy5SoxAIiODRxdwzI yi4ZY2+0jylqdvAclxcxMTbQpDPkOBIbhJiGf1fU= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B23C56EFDA for ; Wed, 4 May 2022 16:09:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B23C56EFDA Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1nmEl7-0003UV-Q4; Wed, 04 May 2022 16:09:38 +0300 Date: Wed, 4 May 2022 16:07:24 +0300 To: Denis Smirnov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <6e27e4ad0577f7d3f69747eb3766fd00b902b602.1651202921.git.sd@picodata.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e27e4ad0577f7d3f69747eb3766fd00b902b602.1651202921.git.sd@picodata.io> X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9086B0A94CD1F151448582A4BE10ACC7C79FC887CBB8B2133182A05F5380850404C228DA9ACA6FE272940CBE658BDCDD5C980F1A8263222C5C209CA0CD25370F41AF5A76E64767279 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C8DD139BC0BB8586EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376F127A835590024F8F08D7030A58E5AD1A62830130A00468AEEEE3FBA3A834EE7353EFBB5533756612A14A871D1BD86C78D0D9CDBD1EA63A6C6C89E7F1B602E9A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7ABB305BD10C6E5099FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3CF36E64A7E3F8E58117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006379DF1562AB18BA749EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A566EA0747DDF5DE92F7F9D9659007440D9332EC5E9B6FAADAD59269BC5F550898D99A6476B3ADF6B4886A5961035A09600383DAD389E261318FB05168BE4CE3AF X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3475AE8838CC1BF58E539444FA6927BD011109BD4ACEF2A4BAB9C20ACE084D3A63999CE5DC125170BB1D7E09C32AA3244C76056AEADCB924BA050F6F6C27872AA97101BF96129E4011729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojD/QvxFEDWC8hGrGtZ9mxqw== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D62B34252E5B7AC5C05EF4C7151307BD4F0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/1] build: missed header when -DLUAJIT_DISABLE_JIT=ON X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Denis! Thanks for the patch! Please, consider my comments below. On 29.04.22, Denis Smirnov via Tarantool-patches wrote: > Previously it was impossible to build Lua JIT with disabled JIT > option (-DLUAJIT_DISABLE_JIT=ON flag) because of the missed include. > Fixed. Nit: I proposed the following rewording: | | This patch adds the necessary include. > --- Your branch is outdated regarding "master" (tarantool) branch. So the build is still failing with disabled JIT. Also, it is necessary to introduce new CI jobs with disabled JIT (and mb memprof) -- it allows to avoid such troubles in future. It is a good thing, and help with this is valuable and appreciated. NB: JIT-related (or memprof-related) tests should be disabled for such pipeline. So we need to introduce disabling mechanism by these factors. > src/lj_memprof.c | 1 + Please, check that Makefile.dep.original is updated corresponding new added header. > 1 file changed, 1 insertion(+) > > diff --git a/src/lj_memprof.c b/src/lj_memprof.c > index d4a639fd..4a35613c 100644 > --- a/src/lj_memprof.c > +++ b/src/lj_memprof.c > @@ -11,6 +11,7 @@ > #include > > #include "lj_arch.h" > +#include "lj_jit.h" > #include "lj_memprof.h" > > #if LJ_HASMEMPROF > -- > 2.32.0 (Apple Git-132) > -- Best regards, Sergey Kaplun