From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B57826ECC0; Mon, 4 Apr 2022 11:48:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B57826ECC0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1649062081; bh=w2ZFm9A102mhLP29BmRskjsYOeuQ8cdC2y+LYQdENWk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=q8Q/ql+enxn40149nVV0fW1jX6o40KnG/aY676eO/moiru+ujvLrn+AQsp7ZcAYoR TkwDWkfvC2BvoFQ1ecc5P7aoQ0TKDXjzE56hgl2a9kUothiYLnhLnrfTYsJAR+Lfls SIoiGN/OtzuyYkhgiRwO96Q95JHwqEtF73YqMQHc= Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 46E456ECC0 for ; Mon, 4 Apr 2022 11:48:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 46E456ECC0 Received: by smtp37.i.mail.ru with esmtpa (envelope-from ) id 1nbINT-0006PA-KS; Mon, 04 Apr 2022 11:48:00 +0300 Date: Mon, 4 Apr 2022 11:45:52 +0300 To: Maxim Kokryashkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD90FA8EB11E8F64C5639B5F8A763EE6707152DF9FAA08A7BCF182A05F538085040D5AD7781117D1A01EC648B8BEA736A9358409BE80E4A185CDA9D852D941C37D4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72E4E5201E1C2E308EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376473F174BDE74BA48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8AA28B66F07100631F9588BAB53588A90117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B65D56369A3576CBA5089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A5C2BAF8D70BDC80B82F87A0E200657D341BB837C517E7E2E4D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA756036BD11B5BF1297410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A63B03BCD35E0C0A45F411F577770E4B7764E3806E131D1946DF32B38084E5D87E876899752DCAB41D7E09C32AA3244CD5E77FBD825FD15C2FDFF08165F748A8FE8DA44ABE2443F7927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojAdqTKMIlqjNF9Td0Fncnkg== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4C2E39AF90D6500147E4DA8E66A164032ADBEB03443A6C751F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v6 0/2] memprof: C-symbols resolving X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the fixes. On 22.03.22, Maxim Kokryashkin wrote: > Changes in v6: > - Fixed comments as per review by Sergey > - Added tests for newly loaded symbols resolution > > --- > >> +#include > >> +#include > > > > and are included inside lj_def.h, so this include is excess. > Relying on includes in other header files is a terrible practice. Ignoring. Yes, but it is common for LuaJIT. :) > > > -- > 2.35.1 > -- Best regards, Sergey Kaplun