From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D9E3A6ECDB; Tue, 15 Mar 2022 10:58:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D9E3A6ECDB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1647331134; bh=aiTFKFH+B7071xmBPrs6G+9iFT5dEQ8AcPuxW84u4PE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=AOzQI9z8Mvv5xZw+Sr9OT2YL69DpGVrEotD0QI55csau2t3QtgXEqDk+u50o0ZKpO AGRC6vHH6k7q2CKB8aZ7oy/bcdXKjGnXeOUesP3bFKL497XbEQMZ+xv/iqROqYg7k7 c6rpHFPHxR2cjqZrNp7E/ogtlS2AIV5PJelbujwc= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 372EC6ECDB for ; Tue, 15 Mar 2022 10:58:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 372EC6ECDB Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1nU24x-0002g1-AP; Tue, 15 Mar 2022 10:58:51 +0300 Date: Tue, 15 Mar 2022 10:56:49 +0300 To: Mikhail Shishatskiy Message-ID: References: <20211202110329.664738-1-m.shishatskiy@tarantool.org> <20211202110329.664738-2-m.shishatskiy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211202110329.664738-2-m.shishatskiy@tarantool.org> X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD95C8DF32398C35CA633AC8158FD68276C79E92F1BB1950288182A05F5380850404C228DA9ACA6FE27B509CF8DFC6955206BEE7733BAB3427FDFA9CF691D4E947C8B606603250A5924 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE789066434B85BF7C7EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374ECA27954A00B6C3EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BEBC5CAB6D411FFA6382047A1AE872E620E4B6811F1C824B7CC7F00164DA146DAFE8445B8C89999728AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8A9FF340AA05FB58CF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B9F5955FECEF5819E75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A5CED810372C2620D2DA876896B3BE58E68FDE90E0DDDFF6FED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA751B03672033AC981D410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D95739AEDB3821B4A3B27FD28F4BD7C4629FB7F61D4D0482AA40E9236303632D582C12CF6A6FCDCA1D7E09C32AA3244CFEA5CB1282EC7DF0F3102725AF6F550251E887DA02A9F7BFFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojAOECQP7bIlaaw+wxQi+xbg== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D61AF905A21CEC85025664432B005391210FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 1/3] memprof: add symbol epochs X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! Please, sorry for such long response. LGTM, except a few nits regarding the commit message. Also, maybe we should add some tests to the patch? Case for traces looks easy, doesn't it? On 02.12.21, Mikhail Shishatskiy wrote: > There may be situations, when new prototype or trace has the same > address than the previously dumped one. In this case, the new symtab > entry will shadow the preceeding, and if we demangle symbols when all Typo: s/preceeding/preceding one/ > the events are parsed, we can get irrelevant information. > > For this reason, the symtab now stores not a single entry, but array of Typo: s/array/the array/ > entries for each location. The structure was extended by the field > representing the generation of symtab entry associated with this > particular location entry. Also, the API has extended > by function symtab.new_loc(symbols, addr, line, traceno) so that it can > assign an epoch for a new location. > > Part of tarantool/tarantool#5815 > --- -- Best regards, Sergey Kaplun