Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] ci: introduce GitHub Actions
Date: Fri, 4 Mar 2022 17:11:23 +0300	[thread overview]
Message-ID: <YiIeC5I5JtKpWvOS@tarantool.org> (raw)
In-Reply-To: <Yh+pBkvv/xkZvpIR@tarantool.org>

Hey, it's me again.

On 02.03.22, Igor Munkin wrote:
> Max,
> Thanks for your review!


> > >
> > >So maybe we can use matrix to cover all these workflows as showing
> > >here[5], using environment variables to determine setup step for the
> > >particular OS (macOS or Linux)?
> > >
> > >But maybe I am overcomplicating things, so feel free to ignore. :)
> > I think that in our case it is actually better to have a lot of workflow configs.
> > From time to time we encounter some issues only on certain operating
> > systems, so it is great to have the ability to fine-tune workflow config only for
> > one particular OS.
> Such cases should be handled in tests, not in workflows (consider
> Tarantool workflow using LuaJIT tests), so I've left one workflow per
> each supported OS (i.e. Linux and macOS). Ignoring.

Well, I was wrong, you were right -- there was a big mistake to merge
workflows for x86_64 and aarch64. At first, there is no support for the
latter in 1.10 and 2.8. Furthermore, macOS runners on m1 are using
Rosetta for Github Actions' workflows, so we need use `arch -arm64`
prefix for each command and I've failed to make it respect <matrix.ARCH>

So, I've reverted the related changes. Again, thanks for your inputs!

> >  
> > Best regards,
> > Maxim Kokryashkin
> >  
> -- 
> Best regards,
> IM

Best regards,

  reply	other threads:[~2022-03-04 14:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 13:15 Igor Munkin via Tarantool-patches
2022-03-02  7:53 ` Sergey Kaplun via Tarantool-patches
2022-03-02 17:13   ` Igor Munkin via Tarantool-patches
2022-03-03  8:33     ` Sergey Kaplun via Tarantool-patches
2022-03-02 17:14   ` Maxim Kokryashkin via Tarantool-patches
2022-03-02 17:27     ` Igor Munkin via Tarantool-patches
2022-03-04 14:11       ` Igor Munkin via Tarantool-patches [this message]
2022-03-04 11:55 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YiIeC5I5JtKpWvOS@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] ci: introduce GitHub Actions' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox