From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 65ED86E454; Thu, 3 Mar 2022 14:02:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 65ED86E454 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1646305357; bh=L+IqNQorAkwI2SiOktgJTveYXjDuvrlGDhnIMLtaves=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=EHIs2Cmu1102tMVv5w/RT+XY+I18A7u9S9WgO/x1rQ0gcz634p8jQr3HW4zGiq4nV I+nghRs06Fp+A+lcY5ks9BRyJq0BOwAnX0ZvwNQ/ku68n/X/L/7MY44YJw5DmkjPwd TCbVvF1wK25GcQLnvntaYwm0t5X1Bwqbfj9v0ntw= Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BFB816E454 for ; Thu, 3 Mar 2022 14:02:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BFB816E454 Received: by mail-lf1-f43.google.com with SMTP id u20so7794072lff.2 for ; Thu, 03 Mar 2022 03:02:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=x9jP79GrR9INfAcKzUNJIYN2TGL1OmDghYBBDCO8/TY=; b=2s22tKEOQbPnvLWsNEvQr3o7Dv7Vhlcrv1Qjgs7DEtt7XAOXEjGGfc627wrVLtE2gK t3b0d6VrP+YoHniHm0kdF+YlLKtpfYOMw6/uJ4QNaU9q9eYuGAia0L5BWR2hyMWxMXZ5 bFniyS8LCH/Cy43ZOvSTNWQfK1kEe8QW9mdb5oZdTrRLtFJ9pTZqbrt2ptbTN7ASOICa nUCuilqamldz2vydL1BnIpyTuJZQUioox437Ik7Za4YJ4l6Hi5MPKJh8+UONRvudh/To PqxAH5wmNFLNTainkr9nS1XROCiaYAT7+NFnJYvomTC/IiqwsLpMS7bEaAkQFRkTyOhq VJ0g== X-Gm-Message-State: AOAM530zquP6vjgu+cGConqPEP/akUSJn/AlBR6woAr9rWNOIxkLbKpf 1KTRCfe4PWUVr+QjtbZFLWW8LKWhibQ= X-Google-Smtp-Source: ABdhPJxotVrxKFhV4zp/LLbXkuYgoGyQnvBNjwOi9pVq0PbMxKQNNS8Cndn4Ob/XBrKRCQ7luunRTQ== X-Received: by 2002:a05:6512:168f:b0:438:2591:7f5d with SMTP id bu15-20020a056512168f00b0043825917f5dmr20946234lfb.690.1646305354303; Thu, 03 Mar 2022 03:02:34 -0800 (PST) Received: from grain.localdomain ([5.18.251.97]) by smtp.gmail.com with ESMTPSA id b36-20020a0565120ba400b00446e0ed499dsm64632lfv.87.2022.03.03.03.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Mar 2022 03:02:33 -0800 (PST) Received: by grain.localdomain (Postfix, from userid 1000) id 6AA2C5A0020; Thu, 3 Mar 2022 14:02:32 +0300 (MSK) Date: Thu, 3 Mar 2022 14:02:32 +0300 To: Serge Petrenko Message-ID: References: <20220302202711.1003906-1-gorcunov@gmail.com> <20220302202711.1003906-4-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.1.5 (2021-12-30) Subject: Re: [Tarantool-patches] [PATCH v31 3/3] test: add gh-6036-qsync-order test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tml , Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, Mar 03, 2022 at 01:08:59PM +0300, Serge Petrenko wrote: > > 02.03.2022 23:27, Cyrill Gorcunov пишет: > > To test that promotion requests are handled only when appropriate > > write to WAL completes, because we update memory data before the > > write finishes. > > > > Part-of #6036 > > > > Signed-off-by: Cyrill Gorcunov > > > Thanks for working on this! > > Please consider the following cosmetic changes: > > 1. There's build_and_add_server as an alias for build_server + add_server > > 2. Use luatest.assert instead of plain assert everywhere > > 3. Use exec instead of eval everywhere Thanks a huge, Serge! Will update and force push.