From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 332A46E454; Wed, 2 Mar 2022 09:02:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 332A46E454 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1646200926; bh=L9N246Vzn0exavLZfhCR3Go0autNbSeO1qEk4PV+flU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OCRiPE+rF/cLM7dOq/ZE3Da5jEwAT0c00RHew8dgdeg3mPE/hs2pI0QmxbnrBQUyE XfuUYgc/VVYe+gfn3TftvlezF5B+2ILAOzkrWDmtr1ghSKXUUXVaLXsgfapp+hT8ZZ PabBv7WXRpNsMaE8hIxdEckPRxsk1Iy9j6wYFEHk= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5CC116E454 for ; Wed, 2 Mar 2022 09:02:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5CC116E454 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1nPI3o-000313-E4; Wed, 02 Mar 2022 09:02:04 +0300 Date: Wed, 2 Mar 2022 08:59:57 +0300 To: Maxim Kokryashkin Message-ID: References: <20220228235445.1841219-1-m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220228235445.1841219-1-m.kokryashkin@tarantool.org> X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9C7814344C8C501C848375AF9090CB57CECA83A47433AF06A182A05F538085040CCDBE3FC36184072046579B8F5D9DF460871E6ADCA556C55436A992FEB684D6C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E50EC9128971FD6EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063776672C316918EFDB8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C7EA738C2BD30A66400CCEB62139DE91117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAA867293B0326636D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6B1CFA6D474D4A6A4089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A5D2FB86914A85393F473DAC85DDA4E1A82C26B6569935EE19D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F78D6440C3F49C15410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D345DE7771146E56B0824B8510525ED3BC4E05B153F5CFB8D0EFA119C7FE789D376795857C597FCFC771D7E09C32AA3244CD5BD293548143F9E4449290F18B0E0E07101BF96129E4011927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojEE37XCRm9PCn9DY27PwSWQ== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D63D914C25CEC3C19B4BE0C0087A0684BB0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2] test: adapt test checking reversed function X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the fixes! LGTM. On 01.03.22, Maxim Kokryashkin wrote: > diff --git a/test/PUC-Rio-Lua-5.1-tests/pm.lua b/test/PUC-Rio-Lua-5.1-tests/pm.lua > index e364ff9d..61f437f6 100644 > --- a/test/PUC-Rio-Lua-5.1-tests/pm.lua > +++ b/test/PUC-Rio-Lua-5.1-tests/pm.lua > @@ -206,12 +206,16 @@ function rev (s) > return string.gsub(s, "(.)(.+)", function (c,s1) return rev(s1)..c end) > end > > -local x = string.rep('012345', 10) > --- FIXME: The first Tarantool's fiber has only 512Kb of stack. > --- It is not enough for this recursive call. > +-- The first fiber in Tarantool has only 512Kb of the stack, > +-- which is not enough to handle such a deep call chain. Thus, > +-- the chunk of code being considered cores with SIGSEGV as a > +-- result of C stack overflow. > +-- > +-- This test is adapted to match the stack size of the first fiber in > +-- Tarantool by decreasing the string length. > -- See also https://github.com/tarantool/tarantool/issues/5782. > --- The test is disabled for Tarantool binary. > --- assert(rev(rev(x)) == x) Minor: Please, add the comment, that the following example crashes both Tarantool and LuaJIT (so the problem with C stack overflow still exists): | luajit -e ' | local function rev (s) | return string.gsub(s, "(.)(.+)", function (c,s1) | return rev(s1)..c | end) | end | local x = string.rep("0", 1000) | rev(x) | ' > +local x = string.rep('01234', 10) > +assert(rev(rev(x)) == x) > > > -- gsub with tables > -- > 2.35.1 > -- Best regards, Sergey Kaplun