From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D65EF6E454; Wed, 2 Mar 2022 20:30:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D65EF6E454 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1646242255; bh=KNd3hCSuT+e1zMtGgipfo2QkflNDpFDPDlS1bndtMsw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=nzMg9mbnxk0udL4s+1hBPrdOmuYAXQ5Q6LlQlUsOPngeo2sw+mPrSTQcHbJ8+/JOA isgej+1AN3Sl3Wi25gFl3KLMIVzeanyCu9qTynU6XWCs7JkLx37BmWs/5lIR24v4JC Dg0fX2BXH6lLevNuE+ARIj4zluS21e0PyzxUzGO4= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E200D6E454 for ; Wed, 2 Mar 2022 20:30:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E200D6E454 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1nPSoP-0007ZO-T5; Wed, 02 Mar 2022 20:30:54 +0300 Date: Wed, 2 Mar 2022 20:27:34 +0300 To: Maxim Kokryashkin Message-ID: References: <1646241251.864885502@f480.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1646241251.864885502@f480.i.mail.ru> X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9BE929572AA3D6CA1A2AB2B581E5F725399B3871A01C2BF6400894C459B0CD1B94D8CB91EABC7C0193108F06FC9377EC9C7FA9622B265BEDF421CDA9B766B0189 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F544D30F1A6FA191EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D0C488966F20D4908638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8394DEC3D6103AA4CF053D374BF64C8CE117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18C26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6D635BA3ABDB36C18089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A51DED9945CB89F1836CF140EAC872586CBAD7BE8DD057F7F3D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7578EBB57D26FA90A6410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3468964757141B82E0756E2D02055CF4E1F3C6B4B9D488ED4BC20C273366AA29C14719F83903E047B21D7E09C32AA3244C5305AA67252DBDE32F91D0B818489BD405AB220A9D022EBC927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojEE37XCRm9PAKPCczhgsIOA== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D6DEED8C781905396A9E98B4DA1380D056A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ci: introduce GitHub Actions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for your review! On 02.03.22, Maxim Kokryashkin wrote: > > Hi! >   > Thanks for the patch! > LGTM, except for comments by Sergey and a few of mine: Added your tag: | Reviewed-by: Maxim Kokryashkin > > > >> + # We use a trick here: define the concurrency group as 'workflow > >> + # run ID' + # 'workflow run attempt' because it is a unique > >> + # combination for any run. So it effectively discards grouping. > >> + # > >> + # XXX: we cannot use `github.sha` as a unique identifier because > >> + # pushing a tag may cancel a run that works on a branch push > >> + # event. > >> + group: ${{ ( > >> + github.ref == 'refs/heads/tarantool' || > >> + startsWith(github.ref, 'refs/heads/tarantool-')) && > >> + format('{0}-{1}', github.run_id, github.run_attempt) || > >> + format('{0}-{1}', github.workflow, github.ref) }} > >> + cancel-in-progress: true > IMO, it’s better to use a combination of `github.sha` + `github.event`, > since all you want is to suppress cancelation caused by tag push. > It is essentially the same, but at least it preserves the semantics. I use the same recipe as in Tarantool workflows, so I leave it unchanged. Anyway, I saved your inputs for our DevX team, thanks! > > > >So maybe we can use matrix to cover all these workflows as showing > >here[5], using environment variables to determine setup step for the > >particular OS (macOS or Linux)? > > > >But maybe I am overcomplicating things, so feel free to ignore. :) > I think that in our case it is actually better to have a lot of workflow configs. > From time to time we encounter some issues only on certain operating > systems, so it is great to have the ability to fine-tune workflow config only for > one particular OS. Such cases should be handled in tests, not in workflows (consider Tarantool workflow using LuaJIT tests), so I've left one workflow per each supported OS (i.e. Linux and macOS). Ignoring. >   > Best regards, > Maxim Kokryashkin >   -- Best regards, IM