From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6B1E16E454; Wed, 16 Feb 2022 15:47:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6B1E16E454 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1645015649; bh=J3hNX0Iunmhv6/ovRY+wIUsHyBupfBaX6PFRyN3m3YM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=JOZxbZtimsjm/KjabhmWoMR5dYFQTVe9c6KMkS7fr0WwScn6whswpfHDXEsWPnMpu 52V6ckxgeoN5xj7Q1LsQiz//CgzpkcuTfzqO5sx9ZgKqP/Xu5v1tczY6yaJK0HD9dv XYYvQjoxewUwRC97mqM3PDcG6U7VumQ+iGA+wwNg= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 403D46E454 for ; Wed, 16 Feb 2022 15:47:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 403D46E454 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1nKJi6-000735-EB; Wed, 16 Feb 2022 15:47:06 +0300 Date: Wed, 16 Feb 2022 15:43:49 +0300 To: Sergey Kaplun Message-ID: References: <20210924142857.66614-1-m.kokryashkin@tarantool.org> <1633982569.350125559@f192.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD923F1B5F87BDC70E6CD687A88BADF9F55440F8199202B6F61182A05F538085040C1E3BD7A45F1973FF20F3AEA0C89EFAB7BA3F898BF075413F97F53D969909116 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DECE8D0A5E25C0FCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063764345650F0BBEB0B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8661BFE1421BE761D26F4AF34B83D4093117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6753C3A5E0A5AB5B7089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A5670B64C23DA3386FCC50EDEA05DC29D7EF47E7D620A1B304D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA754D8E939D8DBE9AFC410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34EC58E35A639A247133AFDA5A4432A13016C5E83F0DD497ECA6A2D8C6E2C62A03D4A8813AB1BE05951D7E09C32AA3244C9E2B47EDF564D95A09F77778935BC36D795D98D676DD64D083B48618A63566E0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj5x0cJQaqqfoqE4vSl6/KEA== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D63E3B872EC026F3F44007F999591725F6A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: adapt tests checking loading bytecode files X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, On 12.10.21, Sergey Kaplun wrote: > Hi! > > Thanks for the fixes! > > On 11.10.21, Максим Корякшин wrote: > > >> --- FIXME: Loading bytecode with an extra header (BOM or "#") > > >> +-- Loading bytecode with an extra header (BOM or "#") > > >> -- is disabled for security reasons since LuaJIT-2.0.0-beta10. > > >> -- For more information see comment for `lj_lex_setup()` > > >> -- in . > > >> -- Also see commit 53a285c0c3544ff5dea7c67b741c3c2d06d22b47 > > >> -- (Disable loading bytecode with an extra header (BOM or #!).). > > >> -- See also https://github.com/tarantool/tarantool/issues/5691 . > > >> --- The test is disabled for LuaJIT. > > >> -prepfile("#comment with a binary file\n"..string.dump(loadstring("print(1)"))) > > >> --- RUN("lua %s > %s", prog, out) > > >> --- checkout("1\n") > > >> - > > >> -prepfile("#comment with a binary file\r\n"..string.dump(loadstring("print(1)"))) > > >> --- FIXME: Behavior is different for LuaJIT. See the comment above. > > >> --- The test is disabled for LuaJIT. > > >> --- RUN("lua %s > %s", prog, out) > > >> --- checkout("1\n") > > >> +-- The test is adapted to LuaJIT behavior. > > >> +prepfile(string.dump(loadstring("print(1)"))) > > >> +RUN("lua %s > %s", prog, out) > > >> +checkout("1\n") > > > > > >May be it is better to test `NoRun()` for 1 binary file with a comment at the > > >first string and `Run()` for another binary file without the comment. > > What are your thoughts about this idea? What are you going to check with this? To check whether unsafe bytecode loading is still disabled? > > -- > Best regards, > Sergey Kaplun -- Best regards, IM