From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2B1DD6E21E; Wed, 16 Feb 2022 13:41:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2B1DD6E21E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1645008071; bh=ppurG39+cOBO/9N127i4/n6xCR9nL601+cXNu5RU+zY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=og5YVP4LI915VK+yHjGtndLG2OQlOzGevz5vVY7n5sOMmIodKLJ13TJrfSHZugGH0 c2oSroJGa9q/vfhmpSFmJrw2fB+OWPqmJ0L6SLLQezmuBt1L+WebBH7VDgbrkST16v 1mK5L6wk8kPnTD1aQineJ/jHH87Irs86dG/P5wGA= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4A8B16E454 for ; Wed, 16 Feb 2022 13:40:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4A8B16E454 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1nKHjt-0002WU-BE; Wed, 16 Feb 2022 13:40:49 +0300 Date: Wed, 16 Feb 2022 13:37:32 +0300 To: =?utf-8?B?0JzQsNC60YHQuNC8INCa0L7RgNGP0LrRiNC40L0=?= Message-ID: References: <20211013155500.2639254-1-m.kokryashkin@tarantool.org> <1642765265.228458223@f472.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1642765265.228458223@f472.i.mail.ru> X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD923F1B5F87BDC70E65A8F887F9034DEDC9D51F702AE775558182A05F5380850409935D0B5C573487FD81ABE94C047AFDC7248317F7937BEFBF7CFAEA11FDB26FB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C2204D4F9A221771EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FACF2191C0719DEE8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A72E8499CA4B7DD5601DC296E4459A78117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6D0C9BB9AE6BD5D69089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A5F889759EB0AFBA80BED9EAB06103A8899BBB5A1FD6B68CC0D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75438CC92D4039F4E2410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3414C91BA6844B96CA31DA21B9822D8475BB6BB1524EF72D17A11D9AFA1DC48CDA9A53187CA7DE3E371D7E09C32AA3244C92E33A2B9EC3100539D99D385CD46CCCF522A1CF68F4BE058D5DD81C2BAB7D1D X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj5x0cJQaqqfqPBLO+D0qfVg== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D64A8D83EBDB0EA346D8A3ED767490C771A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2] test: adapt disabled tests from PUC-Rio X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org, Maxim Kokryashkin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Here are the remaining nits. On 21.01.22, Максим Корякшин wrote: > > Hi, Sergey! > Thanks for the review! >   > New commit message with your comments in mind: > ========================================================= > test: adapt disabled tests from PUC-Rio >   > Version and status are printed in stdout instead of stderr > since LuaJIT-2.0.0-beta11 (as it is not an error message). This behavior > is the same as in Lua 5.2, so necessary changes in tests can be > adapted from PUC-Rio Lua 5.2 test suite. >   > However, those tests are disabled for Tarantool since its interactive > shell doesn't support '=' at the beginning of statements. > Here is an example: > |$ luajit > |> = (6*2-6) -- === > |6 > | > |$ tarantool > |tarantool> = (6*2-6) -- === > |--- > |- error: ' (6*2-6) -- ===:1: unexpected symbol near ''=''' > |... It's better to use a space between | and the body (like email client does) for readability. So this part should look like this: | $ luajit | > = (6*2-6) -- === | 6 | | $ tarantool | tarantool> = (6*2-6) -- === | --- | - error: ' (6*2-6) -- ===:1: unexpected symbol near ''=''' | ... >   > Part of tarantool/tarantool#5870 > Resolves tarantool/tarantool#5687 Please, move "Resolves" tag prior to "Part of" one. > ========================================================= > >  -- Best regards, IM