From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 279B36E454; Fri, 11 Feb 2022 22:16:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 279B36E454 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1644607008; bh=k8Hnuu5SbWNd67UmsPxS4oei6YdeEpFWlrTVzNhNFNY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZYylcMM5mkn8OgkgLk/vsjwFAY2YcvQWMUp9StEGt6ZF1xqPZWSQGJ3APeU+ut80P 7+y00eSqWH+N7kfOfE2HpYHJcLohnPgFb3jpEHH5MZj44ug3LhuR0TMZIryPY/4/2V qdqUVGU6dixC+cBBn8YUs+6kUidb40W/36NklgN4= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6FA276E224 for ; Fri, 11 Feb 2022 22:15:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6FA276E224 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1nIbOY-0002Lm-LS; Fri, 11 Feb 2022 22:15:51 +0300 Date: Fri, 11 Feb 2022 22:12:34 +0300 To: =?utf-8?B?0JzQsNC60YHQuNC8INCa0L7RgNGP0LrRiNC40L0=?= Message-ID: References: <20210924172519.121517-1-m.kokryashkin@tarantool.org> <1636477156.346911057@f542.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1636477156.346911057@f542.i.mail.ru> X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD94A599DE53EADEE57D22BD4A020C306709115AF22CC0AFC72182A05F538085040D0C8B43834EFEF0501D7E0D1FA2A2447EBA4610AA65D1D9DE4FB29882DE86B9D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE702C8878A98595F58EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F907CB39E8CA2E228638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8DA35511606931ECF2F620BB9FE80E73E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B682BBBAF5DF00056E089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A54CB3449A882A14662D9AAA83F50F9C2772616D75BD6807CDD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7557E988E9157162368E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3435BBF0AC4E3A921CF788E1811CA46FD7FAE3DB6C8CD7C6F907EE302E0E6521489678FACE93D46D6C1D7E09C32AA3244C887DFDF29DFA0AAAFD623D07A84AADB1FE8DA44ABE2443F783B48618A63566E0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj0jP+VWF3k0dm/Hvc3bm8kw== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D621E640663BC26A9DEB1700473015F02AA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: adapt tests checking traceback in tail call X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! LGTM, except a couple of nits. On 09.11.21, Максим Корякшин wrote: > > Hi, Sergey! Thanks for the review! > Here is the new commit message considering your comments: >   > ======================================================= > test: adapt tests checking traceback in tail call >   > LuaJIT does not provide information about tail calls, > unlike, Lua 5.1 does, so a traceback in LuaJIT may be different. >   > Consider this chunck of code: Typo: s/chunck/chunk/. > ``` > local function f(n) >     if n > 0 then >         return f(n - 1) >     else >         coroutine.yield() >     end > end >   > local co = coroutine.create(f) > coroutine.resume(co, 3) > print(debug.traceback(co)) > ``` >   > For LuaJIT traceback looks like the following: > stack traceback: >             [C]: in function 'yield' >             test.lua:5: in function > ``` >   > And for Lua 5.1 it looks like the following: > ``` > stack traceback: >             [C]: in function 'yield' >             test.lua:5: in function >             (tail call): ? >             (tail call): ? >             (tail call): ? > ``` >   > This commit adapts the corresponding test to the behavior of LuaJIT, so > it doesn't check tail calls anymore. >   Please, add "Resolves tarantool/tarantool#5703" here. > Part of tarantool/tarantool#5870 > ======================================================= >   > CI:  https://github.com/tarantool/tarantool/tree/fckxorg/gh-5703-adapt-traceback-tail-call-PUC-Rio >   > Best regards, > Maxim Kokryashkin >   -- Best regards, IM