From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B2E506E454; Fri, 11 Feb 2022 22:15:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B2E506E454 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1644606946; bh=PJQqjVVgniF4nVpqETF4NrYncTL3XfL0PkmIT+ie8i8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=dwO8DhLGmxts5VdMQAQ2kn+XJ6isWYHp1OkWSh1bomqC5ou9h+xYYnBK81n4EmteG VvCM9Y1DZwQ7194ClkU4dwHONA7GIIZNMBmFUjT1zAOgehlzovUCW/3OfHNSzp4VdH /IdB4kFqH5V32oAiMaoU1iPFqjz6+NuFEEFZD47o= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D71266E454 for ; Fri, 11 Feb 2022 22:15:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D71266E454 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1nIbO8-0002DO-0p; Fri, 11 Feb 2022 22:15:24 +0300 Date: Fri, 11 Feb 2022 22:12:08 +0300 To: Sergey Kaplun Message-ID: References: <793426cc622083a73c9f8f2ff34779b7b82cb7f8.1643645066.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD94A599DE53EADEE571759C363865EEC398AABE7354D6E873D182A05F5380850401BE0DBDB144DF2D0C58061FD40F2C752C624EDFC1174F752181ADAC35A3A41E3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F68DA2F3749BB650EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063779018AFA06A12C538638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D802D8F2250D0F3414EE97D2D7FFAD451F117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B9EB32FE0C26A3A4C75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A54D97E17F9A1DF17A33B5DD9EB12795B338B31EC444F95D6CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75D33992D797C36249410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D344A431191C56981FEE72B1F6EC0E39C123E7CF29592EDDC8613BA9702F9937827655A8F1429CA65781D7E09C32AA3244C89AD1F477DB1C5B0DA918F2050BADD8A8894E9C85370243E927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj0jP+VWF3k0c4wXrxae9gaw== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D6FB4A21270606BEF9AABE600E7247FD6CA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 2/2] gdb: add mmudata value to lj-gc output X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! On 09.02.22, Sergey Kaplun wrote: > Hi, Igor! > > Thanks for the patch! > > LGTM, except a single nit regarding commit message below. Added your tag: | Reviewed-by: Sergey Kaplun > > On 01.02.22, Igor Munkin wrote: > > As a result of this patch gc.mmudata> value representing the amount > > of GC object to be finalized is added to output. All auxiliary > > Typo: s/to output/to the output/ Well, I almost sure there is no need for the definite article here. Ignoring. > > > routines are also adjusted a bit since these GC objects are grouped in a > > ring-list. > > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM