From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E50EC6E454; Thu, 17 Feb 2022 12:53:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E50EC6E454 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1645091633; bh=Mu3Xtk4oqPBIcFS97qUxEEkmGvOpWERhsLp4v89AMPs=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=rjF8Ks/0Yx4D/5OXdOw6Qnax2Hlr146bv0js94BEpUYrAguKb7yn3Vf7+Hh6flDv8 Rk5wh0teyXkfl/pqPOzmF5ljziogaNRoxkGjapvmmSAHGD82jVPxmXtUX2gtlYgFER j9ZNkypCokQ6iLtEC5yyXXd68BAIhFQV2qyoyAeM= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 101736E454 for ; Thu, 17 Feb 2022 12:53:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 101736E454 Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1nKdTz-0004NN-B0; Thu, 17 Feb 2022 12:53:51 +0300 Date: Thu, 17 Feb 2022 12:51:47 +0300 To: Igor Munkin Message-ID: References: <20210924142857.66614-1-m.kokryashkin@tarantool.org> <1633982569.350125559@f192.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD923F1B5F87BDC70E69ACDEBD6DF692AD9A8D3308768B9AA79182A05F538085040205E30FFD4F32022A8714E580B7211B2B99F06722B5C7D55434DE3E52AF854E4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F1942E6D70B4A2F0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063745476ED688D943148638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D874C8D1F363BA48FE77C58ABA2764930C117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A5A0D84905A4BB635069BE681CE5681F5024ECECC19FA26697D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA752FA4FC647EE431D9410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349FD10E01B3CDC9E204D58A4E4402BDC8D453BF231CEAAAF20612B120ACA325ADCD4460D3B54439FA1D7E09C32AA3244C613216B8593733D127E80A71E12F4C0BB038C9161EF167A1927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj5x0cJQaqqfq3cwcK64azwg== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB49FED79381279D528AC9CEBA135E813F7A4C99830201F815FF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: adapt tests checking loading bytecode files X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, On 16.02.22, Igor Munkin wrote: > Sergey, > > On 12.10.21, Sergey Kaplun wrote: > > Hi! > > > > Thanks for the fixes! > > > > On 11.10.21, Максим Корякшин wrote: > > > > > > >> --- FIXME: Loading bytecode with an extra header (BOM or "#") > > > >> +-- Loading bytecode with an extra header (BOM or "#") > > > >> -- is disabled for security reasons since LuaJIT-2.0.0-beta10. > > > >> -- For more information see comment for `lj_lex_setup()` > > > >> -- in . > > > >> -- Also see commit 53a285c0c3544ff5dea7c67b741c3c2d06d22b47 > > > >> -- (Disable loading bytecode with an extra header (BOM or #!).). > > > >> -- See also https://github.com/tarantool/tarantool/issues/5691 . > > > >> --- The test is disabled for LuaJIT. > > > >> -prepfile("#comment with a binary file\n"..string.dump(loadstring("print(1)"))) > > > >> --- RUN("lua %s > %s", prog, out) > > > >> --- checkout("1\n") > > > >> - > > > >> -prepfile("#comment with a binary file\r\n"..string.dump(loadstring("print(1)"))) > > > >> --- FIXME: Behavior is different for LuaJIT. See the comment above. > > > >> --- The test is disabled for LuaJIT. > > > >> --- RUN("lua %s > %s", prog, out) > > > >> --- checkout("1\n") > > > >> +-- The test is adapted to LuaJIT behavior. > > > >> +prepfile(string.dump(loadstring("print(1)"))) > > > >> +RUN("lua %s > %s", prog, out) > > > >> +checkout("1\n") > > > > > > > >May be it is better to test `NoRun()` for 1 binary file with a comment at the > > > >first string and `Run()` for another binary file without the comment. > > > > What are your thoughts about this idea? > > What are you going to check with this? To check whether unsafe bytecode > loading is still disabled? Yes, for example. > > > > > > > > -- > > Best regards, > > Sergey Kaplun > > -- > Best regards, > IM -- Best regards, Sergey Kaplun