From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B39826E454; Fri, 18 Feb 2022 22:08:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B39826E454 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1645211293; bh=pN2WrTsE+p94YpynmvoChuxWcbupGuK+YEvKDUvKd38=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=SFtNQRkc0zgt0XvlYqqm4JQhHp6bEFGC0hq5//Hnz8DigTuVZdStiL5RSRsE0Ujlg trZMATiKPNufFxhhRAlm07PgYe+og/DmVN9i9AI5G/yuk4YvcnETu4dOYQrD41IVUF hK3Ltyd7RzscvqmT7uexTvrHdsX6XxgMqo51suuE= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 701E26E454 for ; Fri, 18 Feb 2022 22:08:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 701E26E454 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1nL8by-0007gH-Nz; Fri, 18 Feb 2022 22:08:11 +0300 Date: Fri, 18 Feb 2022 22:04:53 +0300 To: =?utf-8?B?0JzQsNC60YHQuNC8INCa0L7RgNGP0LrRiNC40L0=?= Message-ID: References: <20210930114337.1575120-1-m.kokryashkin@tarantool.org> <1633983560.725061406@f460.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1633983560.725061406@f460.i.mail.ru> X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9D9F17F097F3C889A16FC5755E1997FC430E2C338432F3E05182A05F538085040B7B04AFFCFE885D4406C183FB7D92F89E8090ADE7D0BB5BFBD19EE9A855B511C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7466896EF24E80F12EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376602C647E39EFA3A8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D851705751A5C8CEA8C6B6437EE94C116E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6753C3A5E0A5AB5B7089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A54E438774B22507E1EE2A26C32DAAE7BF5B7A5D84A3E2892CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA752FA4FC647EE431D9410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F05B761BB9C2AA44316FA31A5896C5E4BCE7259F75EB8E90AC5209A1533E0B2B43A44272C3CD237A1D7E09C32AA3244C03AC3D9DC3579653F0E25DBAC90879F185803964308724808D5DD81C2BAB7D1D X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojjM9vSaS3rRNB6VDCEi3N9Q== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D6936C26B52A4E0C7598FA58F18E890A05A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: adapt test checking reversed function X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org, Maxim Kokryashkin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! On 11.10.21, Максим Корякшин wrote: > > Hi! Thanks for the comments.  >   > I agree that it is strange to add this test, as long as it does not test > anything, so I propose to remove it. Why do you think this test checks nothing? It checks with recursive handler. If author wanted to check deep recursion exception, he would add at least (if Lua successfully handles this). I propose to apply the original fix[1], but adjust the comment considering Sergey review: it provides the description, why we can't use the original test, or at least add to avoid the crash. >   > Best regards, > Maxim Kokryashkin >   > >  > >>Hi, Maxim! > >> > >>Thanks for the patch! > >> > >>Please consider my comments below. > >> > >>On 30.09.21, Maxim Kokryashkin wrote: > >>> The first fiber in Tarantool has only 512Kb of the stack which is not enough to > >>> handle such a deep call chain. > >>> The test is adapted to Tarantool by decreasing the string length. > >>> > >>> Closes tarantool/tarantool#5782 Typo: s/Closes/Resolves/. > >>> Part of tarantool/tarantool#5845 > >>> Part of tarantool/tarantool#4473 Minor: Replace both tags above with "Part of tarantool/tarantool/5870". > >> > >>Looks like it should be 5870 instead 4473. Also, 5845 is already > >>closed. > >> > >>> --- > >> > >>Please show the Tarantool branch as well, to show that problem is gone. > >> > >>> GitHub branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-5782-adapt-deep-nest-gsub-PUC-Rio > >>> Issue: https://github.com/tarantool/tarantool/issues/5782 > >>> > >>> test/PUC-Rio-Lua-5.1-tests/pm.lua | 9 ++++----- > >>> 1 file changed, 4 insertions(+), 5 deletions(-) > >>> > >>> -- > >>> 2.33.0 > >>> > >> > >>-- > >>Best regards, > >>Sergey Kaplun > >  [1]: https://lists.tarantool.org/tarantool-patches/20210930114337.1575120-1-m.kokryashkin@tarantool.org/ -- Best regards, IM