From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BFFB66F867; Wed, 2 Feb 2022 20:32:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BFFB66F867 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1643823177; bh=j3mm0uiXZ9xQ5nfqGjLkaZf8SOWVTorvUf0IU4UIYXU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Y0xxweY35YsXjctBjxV1fNk05bv6Dx4Mo8slUR/0fl8uMFC/r2rMNVRyVL2Qy2YTK G4MZBLNCRCgn00zOy8y0SoXKG+OOnmcuik+98P+Jf1zATmgAt0FzVVDsGTmCF0ALdT aVflMOlx9nitRc5wr8EGrwOsDM4jLTEqkcGUcbLM= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C62496F867 for ; Wed, 2 Feb 2022 20:32:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C62496F867 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1nFJV0-00058f-UM; Wed, 02 Feb 2022 20:32:55 +0300 Date: Wed, 2 Feb 2022 20:29:56 +0300 To: Mikhail Shishatskiy Message-ID: References: <20210729093425.179158-1-m.shishatskiy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210729093425.179158-1-m.shishatskiy@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD99F281FB7F96F126D7C01DDBDD3B148B19E689FD613B2B09700894C459B0CD1B9C64012CA4EE635022277B65D824F337EA1B9943201273650485234136DCFB6CD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76ABD3380F320B62CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E149C29A36E092738638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8E130803A765FD4D0DDFED674BB0ED4C8117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18C26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B658CDF7FFE3EBBCC0089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A5EDBE0271961E5F859AB10AC9D5CE88BF2D5CD18C7FFC7BBAD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75BF6B963DD989C0FC410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349EC559D073CA5B6800AE2B3DF59DBD723F865FB5910EEDD498818233A0C560567AC6A6A53E6A1A0F1D7E09C32AA3244C7B0F503980F556A549F3D80E911A6845853296C06374E602927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojKfO1XyIHtDJDoYAjnoOKGw== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D6CE54107D7979EA66F9269CA6F1202D37A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2] memprof: report JIT-side allocations as internal X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Misha, I've checked the patch into tarantool branch in tarantool/luajit and bumped a new version in master. On 29.07.21, Mikhail Shishatskiy wrote: > There are cases when the memory profiler attempts to attribute > allocations triggered by the JIT engine recording phase > with a Lua function to be recorded. In this case, > lj_debug_frameline() may return BC_NOPOS (i.e. a negative value). > > Previously, these situations were ignored and the profiler > reported, that the source line was equal to zero. > > This patch adjusts profiler behavior to treat allocations > described above as internal by dumping ASOURCE_INT if > lj_debug_frameline() returns a negative value. > > Resolves tarantool/tarantool#5679 > --- > > Issue: https://github.com/tarantool/tarantool/issues/5679 > Branch: https://github.com/tarantool/luajit/tree/shishqa/gh-5679-report-jit-allocations-as-internal > CI: https://github.com/tarantool/tarantool/tree/shishqa/gh-5679-report-jit-allocations-as-internal > > Changes in v2: > - Fixed commit title to fit in width of 50 symbols; > - Rebased to the branch [1]; > - Reused default_payload() as a payload to test patch behavior. > > [1]: https://github.com/tarantool/luajit/tree/shishqa/gh-5814-group-allocations-on-trace-by-trace-number > > src/lj_memprof.c | 28 ++++++++++++------- > .../misclib-memprof-lapi.test.lua | 16 ++++++++--- > 2 files changed, 30 insertions(+), 14 deletions(-) > > -- > 2.32.0 > -- Best regards, IM