From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounces@dev.tarantool.org>
Received: from [87.239.111.99] (localhost [127.0.0.1])
	by dev.tarantool.org (Postfix) with ESMTP id 5AE086F873;
	Fri, 28 Jan 2022 18:14:23 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5AE086F873
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev;
	t=1643382863; bh=77H6HhF87cVBrL44PnouLZMF+hrXKoKJ3bWclQfdl7Y=;
	h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:
	 List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:
	 From;
	b=gJaPEWyX3O4mqEXvpg1SjyNGAyjKNOEEq2woOuKlYivcLGhX8ufvwtMlHaC9TW72t
	 YUsMea4IJe2kpubNzkEFfNMWItZyNwa4oxa6l595Sbtq6e0xAvjssQhVojq6vHBA1P
	 QVeDp6QTOHaCvLdEWd/ZfIUPgmTJGPggRVXXr1Ms=
Received: from smtp30.i.mail.ru (smtp30.i.mail.ru [94.100.177.90])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id CF1426F873
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 28 Jan 2022 18:14:21 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CF1426F873
Received: by smtp30.i.mail.ru with esmtpa (envelope-from
 <skaplun@tarantool.org>)
 id 1nDSxB-0006nP-5W; Fri, 28 Jan 2022 18:14:21 +0300
Date: Fri, 28 Jan 2022 18:12:21 +0300
To: Igor Munkin <imun@tarantool.org>
Message-ID: <YfQH1SCaYyyE/qjE@root>
References: <20210820154846.5515-1-skaplun@tarantool.org>
 <YfMSu8jAfEdupEfC@tarantool.org> <YfOoqPjpR7Brwmib@root>
 <YfPtdbl3LuP+Annm@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YfPtdbl3LuP+Annm@tarantool.org>
X-4EC0790: 10
X-7564579A: EEAE043A70213CC8
X-77F55803: 4F1203BC0FB41BD9DB8349C4A72921915232D984A6549A275B74A0BA3688A4391313CFAB8367EF908E2BE116634AD74D6C1667248CB3FE8FB96D991DBBCE6B9C120A037C88EB6996AF1470CB4BE18E90
X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D52C0B46024FCC4BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FF37B1FF54E2C7C48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D80AFCFDCA607FC4A35E04A03F6B9EEA83117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF
X-8FC586DF: 6EFBBC1D9D64D975
X-C1DE0DAB: 0D63561A33F958A512D31CE914A3D2F05D24CB69A21CDE613D17DB48B27D3F1ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0
X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3435BBF0AC4E3A921C7891B91A6623D190E37328F1929CDFA5AE962D4C5F16145909818BEF3DC794BC1D7E09C32AA3244C0C5F2A6D70CDDE7574A8A1A986193F20E646F07CC2D4F3D8FACE5A9C96DEB163
X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojqLK0kLh8sGfjwwRP/gpxuA==
X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4C846EC81EB26BAB136E1F1DD6E4551AA8F7C49E9A1935B18F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196
X-Mras: Ok
Subject: Re: [Tarantool-patches] [PATCH luajit] Fix string.char() recording
 with no arguments.
X-BeenThere: tarantool-patches@dev.tarantool.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
Reply-To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Errors-To: tarantool-patches-bounces@dev.tarantool.org
Sender: "Tarantool-patches" <tarantool-patches-bounces@dev.tarantool.org>

Igor,

On 28.01.22, Igor Munkin wrote:
> Sergey,
> 
> On 28.01.22, Sergey Kaplun wrote:
> > Igor,
> > Thanks for the review!
> > 
> 
> <snipped>
> 
> > > 
> > > I see no assertion running the test in Debug, unfortunately. Could you
> > > please provide the way to hit it?
> > 
> > I build as usual:
> > | $ cmake . -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_APICHECK=ON -DLUA_USE_ASSERT=ON && make -j
> 
> PEBKAC, I totally forgot to enable LUA_USE_APICHECK and LUA_USE_ASSERT.
> I guess it's time to enable both by default for Debug. Thoughts?

I'm OK with it. Not against at least. :)

> 
> <snipped>
> 
> > 
> > -- 
> > Best regards,
> > Sergey Kaplun
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
Sergey Kaplun