From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B40EC6F873; Fri, 28 Jan 2022 16:21:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B40EC6F873 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1643376077; bh=HJOMmYgmpQxRWMqKUmDHtZoAY/G8d3AqKiRieqXrrPw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=if8RX+xdHnm3QwnnAJSdpqtlUElXNa2qtyR1U9jGGPE0aokUUil56fneDCxfWTPxl 5rd/CW6R1B+T2kCMeDSLAlEi3Q/0c5H0rNBzgZwXLcLu7QT8ppPEB5k1D3Bi75Cv6L Op+eDZlcqDpXl131sDahlZMD1harED+Whanc/708= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3FDF66F873 for ; Fri, 28 Jan 2022 16:21:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3FDF66F873 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1nDRBj-00026P-87; Fri, 28 Jan 2022 16:21:15 +0300 Date: Fri, 28 Jan 2022 16:19:49 +0300 To: Sergey Kaplun Message-ID: References: <20210820154846.5515-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9DB8349C4A72921915232D984A6549A275B74A0BA3688A4391313CFAB8367EF908E2BE116634AD74D6BBEBC8BCE01872D5FEB435D0643D1BEFAC39B4AE592FC0CB0371ADBF8103445 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70240200614025CBBC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE78E8764B5BC580342EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BEBC5CAB6D411FFA6CBE20261E050249F0004B9A6885D1994CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B80B9CEB5436E71E375ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5BAC5761FE0F8F9AAFDF0B81C45E38B56CA547406EB7A1D74D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AC223B6CC5B2DFAC8DF1BDCD575F8166CD143C53F407067DD335D7EAB56B3643D3897329888B58FB1D7E09C32AA3244C665F1AC5319088BAF046B1FAC9C0AD97F94338140B71B8EE927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojqLK0kLh8sGdDVVvapqsv9Q== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D6102A38BEA07B96D4156B0BDB5147CC84A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix string.char() recording with no arguments. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, On 28.01.22, Sergey Kaplun wrote: > Igor, > Thanks for the review! > > > > > I see no assertion running the test in Debug, unfortunately. Could you > > please provide the way to hit it? > > I build as usual: > | $ cmake . -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_APICHECK=ON -DLUA_USE_ASSERT=ON && make -j PEBKAC, I totally forgot to enable LUA_USE_APICHECK and LUA_USE_ASSERT. I guess it's time to enable both by default for Debug. Thoughts? > > -- > Best regards, > Sergey Kaplun -- Best regards, IM