From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 14B446F873; Fri, 28 Jan 2022 15:38:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 14B446F873 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1643373481; bh=CiX1G2jqS4mIP8lW48r2B2oWRe1ywauHUvy1Qifq6zQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=nAxEFAoNDDqRxkd904zjTrgeH9Yprd0xY4qEBEygQASRTIzQ9UvZ/cQgJ5hHTVpCB xzdvqDKfnac9LjR96C+ZCpzihUzZrG8Z89FdMnaX+SmPUkIXTkxupjUuQ06xUzLBAX TPfBnfgtWwDq3qitQ387d7oA6q2xH2msdOcj3DCs= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [94.100.177.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CA4126F873 for ; Fri, 28 Jan 2022 15:37:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CA4126F873 Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1nDQVq-0004S7-0f; Fri, 28 Jan 2022 15:37:58 +0300 Date: Fri, 28 Jan 2022 15:35:50 +0300 To: Igor Munkin Message-ID: References: <20211229122731.31617-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9AA78FDF62ECAE61F574C814AB3F23F4AA01FB0D4144D4AE0182A05F5380850407211C6D2B8766DD0D0557D73A9021456D161806DEC69A4AE4C5A44B57EA62DCC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79389E7A2A88AA7BCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379F6495389D012EA98638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8800A08E45FC374BB0D0898AE015E4442117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18C26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B65D56369A3576CBA5089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5AFCE16BB41A26D0F2F16462E31CC61289DB2EC3D3CB4DB3FD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C75F910DBB8BE8980DC4BC4169F14852C5D04141158C6B101B6C1671DCA58F99A21F6C8CEEF5B3861D7E09C32AA3244CA9C3DCFE06CE9EC92B047499F41D6FCE1DD47778AE04E04DFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojqLK0kLh8sGcgwjIGa1OZPQ== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4D4B42E39F5B20D9827BF6B55221641CDD5BDED878FEC4E26F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Actually implement maxirconst trace limit. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, On 28.01.22, Igor Munkin wrote: > Sergey, > > On 28.01.22, Sergey Kaplun wrote: > > Igor, > > > > Thanks for the review! > > > > > > > > > > > > > Issue: https://github.com/LuaJIT/LuaJIT/issues/430 > > > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-430-maxirconst-actually-implement-full-ci > > > > Tarantool branch: https://github.com/tarantool/tarantool/tree/skaplun/lj-430-maxirconst-actually-implement-full-ci > > > > > > > > src/lj_record.c | 5 ++- > > > > .../lj-430-maxirconst.test.lua | 43 +++++++++++++++++++ > > > > 2 files changed, 46 insertions(+), 2 deletions(-) > > > > create mode 100644 test/tarantool-tests/lj-430-maxirconst.test.lua > > > > > > > > > > > > > > > > > diff --git a/test/tarantool-tests/lj-430-maxirconst.test.lua b/test/tarantool-tests/lj-430-maxirconst.test.lua > > > > new file mode 100644 > > > > index 00000000..1829b37d > > > > --- /dev/null > > > > +++ b/test/tarantool-tests/lj-430-maxirconst.test.lua > > > > @@ -0,0 +1,43 @@ > > > > +-- XXX: avoid any other traces compilation due to hotcount > > > > +-- collisions for predictible results. > > > > > > > +jit.off() > > > > +jit.flush() > > > > > > Minor: I'd rather move this part closer to 'jit.opt.start' to save the > > > test structure closer to the other test chunks. Feel free to ignore. > > > > I really want to exclude __any__ JIT work here to avoid false-positive > > hotcount (was precendents during writing this test :)). Ignoring. > > OK, got it. > > > > > > > > > > +test:ok(ntrace_old + 1 == misc.getmetrics().jit_trace_num, > > > > + 'trace number increases') > > > > > > Typo: I doubt we use tabs in Lua sources, but I might be wrong... > > > > I suggest to use quarter tabs indent style as we use for C code and Mike > > use in src/jit/*.lua (see bcsave.lua for example). > > > > There was no precedent before, IINM :). > > See test/tarantool-tests/lj-695-ffi-vararg-call.test.lua[1]. Fixed, repushed. > > > > > > > > > > + > > > > +ntrace_old = misc.getmetrics().jit_trace_num > > > > +jit.on() > > > > +irconst4() > > > > +irconst4() > > > > +jit.off() > > > > +test:ok(ntrace_old == misc.getmetrics().jit_trace_num, > > > > + 'trace number is the same') > > > > > > Ditto. > > > > > > > + > > > > +os.exit(test:check() and 0 or 1) > > > > -- > > > > 2.34.1 > > > > > > > > > > -- > > > Best regards, > > > IM > > > > -- > > Best regards, > > Sergey Kaplun > > [1]: https://github.com/tarantool/luajit/blob/tarantool/test/tarantool-tests/lj-695-ffi-vararg-call.test.lua > > -- > Best regards, > IM -- Best regards, Sergey Kaplun