Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Actually implement maxirconst trace limit.
Date: Fri, 28 Jan 2022 14:55:56 +0300	[thread overview]
Message-ID: <YfPZzHtlH0KoStcz@tarantool.org> (raw)
In-Reply-To: <YfOsh9OJ7yujvsc6@root>

Sergey,

On 28.01.22, Sergey Kaplun wrote:
> Igor,
> 
> Thanks for the review!
> 

<snipped>

> > > 
> > > Issue: https://github.com/LuaJIT/LuaJIT/issues/430
> > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-430-maxirconst-actually-implement-full-ci
> > > Tarantool branch: https://github.com/tarantool/tarantool/tree/skaplun/lj-430-maxirconst-actually-implement-full-ci
> > > 
> > >  src/lj_record.c                               |  5 ++-
> > >  .../lj-430-maxirconst.test.lua                | 43 +++++++++++++++++++
> > >  2 files changed, 46 insertions(+), 2 deletions(-)
> > >  create mode 100644 test/tarantool-tests/lj-430-maxirconst.test.lua
> > > 
> > 
> > <snipped>
> > 
> > > diff --git a/test/tarantool-tests/lj-430-maxirconst.test.lua b/test/tarantool-tests/lj-430-maxirconst.test.lua
> > > new file mode 100644
> > > index 00000000..1829b37d
> > > --- /dev/null
> > > +++ b/test/tarantool-tests/lj-430-maxirconst.test.lua
> > > @@ -0,0 +1,43 @@
> > > +-- XXX: avoid any other traces compilation due to hotcount
> > > +-- collisions for predictible results.

<snipped>

> > > +jit.off()
> > > +jit.flush()
> > 
> > Minor: I'd rather move this part closer to 'jit.opt.start' to save the
> > test structure closer to the other test chunks. Feel free to ignore.
> 
> I really want to exclude __any__ JIT work here to avoid false-positive
> hotcount (was precendents during writing this test :)). Ignoring.

OK, got it.

> 

<snipped>

> > > +test:ok(ntrace_old + 1 == misc.getmetrics().jit_trace_num,
> > > +	'trace number increases')
> > 
> > Typo: I doubt we use tabs in Lua sources, but I might be wrong...
> 
> I suggest to use quarter tabs indent style as we use for C code and Mike
> use in src/jit/*.lua (see bcsave.lua for example).
> 
> There was no precedent before, IINM :).

See test/tarantool-tests/lj-695-ffi-vararg-call.test.lua[1].

> 
> > 
> > > +
> > > +ntrace_old = misc.getmetrics().jit_trace_num
> > > +jit.on()
> > > +irconst4()
> > > +irconst4()
> > > +jit.off()
> > > +test:ok(ntrace_old == misc.getmetrics().jit_trace_num,
> > > +	'trace number is the same')
> > 
> > Ditto.
> > 
> > > +
> > > +os.exit(test:check() and 0 or 1)
> > > -- 
> > > 2.34.1
> > > 
> > 
> > -- 
> > Best regards,
> > IM
> 
> -- 
> Best regards,
> Sergey Kaplun

[1]: https://github.com/tarantool/luajit/blob/tarantool/test/tarantool-tests/lj-695-ffi-vararg-call.test.lua

-- 
Best regards,
IM

  reply	other threads:[~2022-01-28 11:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-29 12:27 Sergey Kaplun via Tarantool-patches
2022-01-27 23:18 ` Igor Munkin via Tarantool-patches
2022-01-28  8:42   ` Sergey Kaplun via Tarantool-patches
2022-01-28 11:55     ` Igor Munkin via Tarantool-patches [this message]
2022-01-28 12:35       ` Sergey Kaplun via Tarantool-patches
2022-01-28 14:16         ` sergos via Tarantool-patches
2022-01-28 15:09           ` Sergey Kaplun via Tarantool-patches
2022-01-28 21:28             ` Sergey Ostanevich via Tarantool-patches
2022-01-28 21:45 ` Igor Munkin via Tarantool-patches
2022-01-29  1:17   ` Sergey Kaplun via Tarantool-patches
2022-02-11 19:09 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YfPZzHtlH0KoStcz@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] Actually implement maxirconst trace limit.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox