From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2B4837118C; Tue, 12 Oct 2021 11:15:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2B4837118C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1634026511; bh=Rj8XkcvQ4DzyukFNutECm6Goa6KyFiXXI5HKaeIUBx0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=om0uAzbTkpbWOBsSfITeItFPb88wS7AFyBj47YbmXgJfX6DzlpalbiNV+t/rwTuKR pdeYCdLXi576JbvgUPw3uz+OG3KM8t9JBbZs5NT+KADntFK5mZCNZcVuUY0R5p+GW9 XmqAZCXAFR24Gqq6DLo/twPAzWj05nPN7b7VaN5s= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 695427118C for ; Tue, 12 Oct 2021 11:15:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 695427118C Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1maCwG-0003vo-FL; Tue, 12 Oct 2021 11:15:08 +0300 Date: Tue, 12 Oct 2021 11:13:27 +0300 To: =?utf-8?B?0JzQsNC60YHQuNC8INCa0L7RgNGP0LrRiNC40L0=?= Message-ID: References: <20210924142857.66614-1-m.kokryashkin@tarantool.org> <1633982569.350125559@f192.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1633982569.350125559@f192.i.mail.ru> X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD922964B4BA091D9AC43D88C0E6241AA868E177A3E5BC866EA182A05F5380850402D696708D2855EBB9D10C658DC41BCC0395429CAE2D17B6DB8CEA96DB75D7D14 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F65C230EDDCD559EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371005780D56A98C20EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F24BAE7A25DFCFCE2239A6392FC0D4F804CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BAEB924C2B054B06E75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A529571592400B334E8B3D745344A1976DAF7C5C791EE64C90D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA759D2A03B9C34326B3410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AF12ADB97C97CD89C74DBA79CA2B2232071D5AD95F5C2476F27B3EC6645B3FDD1914EFEC9CC14DCD1D7E09C32AA3244CDE722074E0A920C996FE8BBFF8009DB924AF4FAF06DA24FD927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojtWOf/ZwQPGHwofrS0q4/Iw== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DF80CB86D154AC0A51FAC5BFCE029F7B10FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED567EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: adapt tests checking loading bytecode files X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the fixes! On 11.10.21, Максим Корякшин wrote: > > >> > >> --- FIXME: Loading bytecode with an extra header (BOM or "#") > >> +-- Loading bytecode with an extra header (BOM or "#") > >> -- is disabled for security reasons since LuaJIT-2.0.0-beta10. > >> -- For more information see comment for `lj_lex_setup()` > >> -- in . > >> -- Also see commit 53a285c0c3544ff5dea7c67b741c3c2d06d22b47 > >> -- (Disable loading bytecode with an extra header (BOM or #!).). > >> -- See also https://github.com/tarantool/tarantool/issues/5691 . > >> --- The test is disabled for LuaJIT. > >> -prepfile("#comment with a binary file\n"..string.dump(loadstring("print(1)"))) > >> --- RUN("lua %s > %s", prog, out) > >> --- checkout("1\n") > >> - > >> -prepfile("#comment with a binary file\r\n"..string.dump(loadstring("print(1)"))) > >> --- FIXME: Behavior is different for LuaJIT. See the comment above. > >> --- The test is disabled for LuaJIT. > >> --- RUN("lua %s > %s", prog, out) > >> --- checkout("1\n") > >> +-- The test is adapted to LuaJIT behavior. > >> +prepfile(string.dump(loadstring("print(1)"))) > >> +RUN("lua %s > %s", prog, out) > >> +checkout("1\n") > > > >May be it is better to test `NoRun()` for 1 binary file with a comment at the > >first string and `Run()` for another binary file without the comment. What are your thoughts about this idea? > > > >> > >> -- close Lua with an open file > >> prepfile(string.format([[io.output(%q); io.write('alo')]], out)) > >> -- > >> 2.33.0 > >> > > > >-- > >Best regards, > >Sergey Kaplun >   -- Best regards, Sergey Kaplun