From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 69F956FC87; Fri, 1 Oct 2021 15:31:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 69F956FC87 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1633091511; bh=BMRCSNp/Ego8ri4zHOtsrD8L9I3FKP8+O9yQLdf1Jh8=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=KinkdD/XipguBy0ls6uQXtoEmEQDwqhj8WIbDx9PTLB/M6U7vkWSrwqjHSSH1iIzU toT9ErLNlW/rpLIbdDCdgUMp8vtBqMablZOrECUCpoVwE+dftSBxv9gmscMi1QAzxN ISoQ1C8cOQnTZOIGMxQ/Xfld0g2rToCEKMybj3tU= Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7E0746FC87 for ; Fri, 1 Oct 2021 15:31:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7E0746FC87 Received: by mail-lf1-f42.google.com with SMTP id x27so38250748lfu.5 for ; Fri, 01 Oct 2021 05:31:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6UviCqwzgSEIAumMOcZ6uiodOuKYC4YksgiLKaqLytc=; b=tDWfd+xIjOwZhtglN/GKb6aSpamY2c/PY6/NysrK5ppMJODqNPJ1G9UFrBXcTDFnNo smvyy3YIzuup4Vr3ONvuSWOwQdXtcD8+BN932q2BnqQEAr/To31ztLRrkGsqcJP2yBwl SM9hMBf6H32/rAIUBAK5RQfo51vexG82w8x0SlwsFn7f9GUrqJk42aW7JQa7Cfjr9cIx t+pUVoAncu0KKRbEoXm8BD1RSPLY6Skk2IsTZljlzNYThASKgE2UWCKM3C153sFOsaDS x5FZs6Fri8EXig0exHH40m1HnlySidu2tnFOE/nEdjc0eD9zTGmFbo7VV3bMG8x/vDuY Rjzg== X-Gm-Message-State: AOAM530TGF8SXNcHCUk/wE+9pD8uw2Gq0f2HWypFoVDumtq+z3SBC+kg Rg73zCPQeMncO559A61kRnPqsaEjLEqlRw== X-Google-Smtp-Source: ABdhPJw48ycqFb1Adoz01cniPtOSQ44jb6Jif++dUdQymNXuywsM+eEGaXHv+GJdRnwec0539vYQtg== X-Received: by 2002:a2e:4a0a:: with SMTP id x10mr11504930lja.146.1633091508413; Fri, 01 Oct 2021 05:31:48 -0700 (PDT) Received: from grain.localdomain ([5.18.253.97]) by smtp.gmail.com with ESMTPSA id r2sm723110lfm.78.2021.10.01.05.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Oct 2021 05:31:47 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id B95EF5A001E; Fri, 1 Oct 2021 15:31:46 +0300 (MSK) Date: Fri, 1 Oct 2021 15:31:46 +0300 To: Serge Petrenko Cc: tml , Vladislav Shpilevoy Message-ID: References: <20210930094445.316694-1-gorcunov@gmail.com> <20210930094445.316694-3-gorcunov@gmail.com> <0c64d172-4fa8-29ec-7845-ff772738c09a@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0c64d172-4fa8-29ec-7845-ff772738c09a@tarantool.org> User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH v19 2/3] qsync: order access to the limbo terms X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Fri, Oct 01, 2021 at 03:14:52PM +0300, Serge Petrenko wrote: ... > > +/** Process a synchronous replication request. */ > > void > > txn_limbo_process(struct txn_limbo *limbo, const struct synchro_request *req); > > Thanks for the patch! > > Mostly ok with one question: > > What about txn_limbo_write_confirm/txn_limbo_read_confirm pairs issued > inside txn_limbo_ack() and txn_limbo_on_parameters_change() ? > > Shouldn't they take the latch as well? I mean, txn_limbo_ack() and > txn_limbo_on_parameters_change() as a whole. Wait, Serge, currently we guard promote_map/max_term, so it won't be read while there is its update on the fly. Thus If only I'm not missing something obvious txn_limbo_on_parameters_change() can't interfere with promote data or race with it anyhow. If you mean some other race then it seems I don't see it yet, but I suspect I might be simply wrong :)