From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6E38E6EC40; Mon, 27 Sep 2021 13:08:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6E38E6EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1632737325; bh=ZXneKuEFg5QLuhp3/NFKCH3qGF6SIL7+u9A6S968PJE=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=B4YQLlBtTzIhSldINj7G7NeyvjIC3RYCkBCYspVlwqWG3b0nf0xANOMI2yLW0a5A7 XqAOreSGIqS+fG447ksul0IuXiCo6GdfrcYotVo5cYRZYPI9L4W2JsdhoMwcbBB5Ew 83LNpu0+PfvTXPpy3sEdojbdArwzC4aAR8QcAVi4= Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5816C6EC40 for ; Mon, 27 Sep 2021 13:08:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5816C6EC40 Received: by mail-lf1-f42.google.com with SMTP id g41so74852265lfv.1 for ; Mon, 27 Sep 2021 03:08:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6ApcEeG9YuE5poI8rfbn+/OFBupRGWxaWQxawu0iqAU=; b=gKV1g4umIqXj6Mv/dJNLK+b3XeOs4+z77N3el2NVR1ZSJjthXxq3NJjqiOOuN69FZ6 BimuO3UnfEPuJJaar4RikTPOWE3q0GtiBCzqit50dflRlcJhHTSmGC7NGck3l1RIAlum lLUsWmhSUKP+PmgOSaMmc1mWreca/zdepQRUb6iym4FvnW1JU/FgCokAgr+wTbxqSLoZ 5ZCI/6PfbutATxPkMJLhjjURtPzPeMP/IsarDF6v6Qgu03lFYxcu39cKcoIJCj1gGvQ6 OVZQZ+9X7kHzXARa1fVu9nH91eD/I0zNpD+K6G2gqlHyFdw1hblAOs2ehMsCXziKQtdb 6JVQ== X-Gm-Message-State: AOAM5334yZz6dN1GKV5a9eb0viCU8Hnz3Snzw+pxhNUBbANoXXW3GdIj F5lfLC/QCRPWy+F5rPaKvxeNIW1R5zmkEQ== X-Google-Smtp-Source: ABdhPJyY74cvoaiAG4ntFySN5vT5XxLWUJ4+gh5eEorZpxef92AxE/ZIOMiSErSTawZiKwuWzBKDnw== X-Received: by 2002:a2e:5005:: with SMTP id e5mr27438434ljb.471.1632737323155; Mon, 27 Sep 2021 03:08:43 -0700 (PDT) Received: from grain.localdomain ([5.18.253.97]) by smtp.gmail.com with ESMTPSA id q11sm1922718ljp.91.2021.09.27.03.08.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 03:08:42 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 559E95A001E; Mon, 27 Sep 2021 13:08:41 +0300 (MSK) Date: Mon, 27 Sep 2021 13:08:41 +0300 To: Vladislav Shpilevoy Cc: tml Message-ID: References: <20210922130535.79479-1-gorcunov@gmail.com> <20210922130535.79479-6-gorcunov@gmail.com> <75b1d7bf-a057-d318-945b-86668715ae51@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <75b1d7bf-a057-d318-945b-86668715ae51@tarantool.org> User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH v17 5/5] test: add gh-6036-term-order test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Sun, Sep 26, 2021 at 04:30:38PM +0200, Vladislav Shpilevoy wrote: > > +if INSTANCE_ID == "master" then > > + box.cfg({ > > + listen = unix_socket(INSTANCE_ID), > > + replication = { > > + unix_socket(INSTANCE_ID), > > + unix_socket("replica1"), > > + unix_socket("replica2"), > > + }, > > + replication_connect_quorum = 1, > > + replication_synchro_quorum = 1, > > + replication_synchro_timeout = 10000, > > + replication_sync_timeout = 5, > > 1. Why do you need sync_timeout 5? To make sure it has some sane short value, our default 300 seconds is too big I think. > > + > > +--box.ctl.wait_rw() > > 2. Please, remove commented out code. ok > > +box.once("bootstrap", function() > > + box.schema.user.grant('guest', 'super') > > +end) > > diff --git a/test/replication/gh-6036-term-order.result b/test/replication/gh-6036-term-order.result > > new file mode 100644 > > index 000000000..6b19fc2c8 > > --- /dev/null > > +++ b/test/replication/gh-6036-term-order.result > > 3. Please, use prefix gh-####-qsync to be consistent with other qsync tests. Having > 'qsync' in the test name helps to run all qsync tests in a single command > > python test-run.py qsync sure, will do > > +test_run:switch("replica2") > > + | --- > > + | - true > > + | ... > > +box.ctl.demote() > > 4. I dropped all 3 demotes and the test passed. Why do you need them? To make sure none of the fresh booted up nodes are owning the limbo even if something is changed in future inside test-run engine (test engine is not a stable API while our demote() operation is part of API and I can be sure that I may don't care how exactly nodes has been started, they all won't be owning the limbo after this command). > > +term_max_wait4 = term_max_master > > + | --- > > + | ... > > +if term_max_wait4 < term_max_replica1 then term_max_wait4 = term_max_replica1 end > > 5. How is it possible? The master did more promotes, it should have a > bigger term for sure. IIRC I've hunting a race buggy testcase and left this snippet untouched. So this snippet simply sneaked in, it is harmless, I'll cleanup, thanks! > > > +test_run:cmd('delete server replica2') > > 6. Can you add some data to the test? Which before the patches was applied, and now > is rejected/nopified. Otherwise you added a lock, tested the lock, but if I move > the data filtering before the lock, your test still will pass. Will try, thanks!