From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 57F5F6EC40; Mon, 27 Sep 2021 10:58:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 57F5F6EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1632729533; bh=rgbksAR8o0/E5Msv7p83JHxVo3+BglUU3csXFk4Joj4=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=kBvWjcz86eh+3kWnJuUH74kW+apeoxa698a7dVuM2bZJRlk/4iJl1j/IkbI2kTf9X rYMUtwYzIJzwO5gTudB9WytMSw5AH3iMlbjd5I6fywksC/p9BylEey2kahx+m9hhd1 tevExtne209RGyowOBpUspvl0Z/9VpD4SbXbbyeg= Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3B2C56EC40 for ; Mon, 27 Sep 2021 10:58:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3B2C56EC40 Received: by mail-lf1-f42.google.com with SMTP id t10so73470315lfd.8 for ; Mon, 27 Sep 2021 00:58:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=hBO+NGgZTUTWwp30HUZBvZJ8NPBbJzk43LGSVc+MMcw=; b=zRtqOxZBvJC61Gv9Yk+rnSQVaBv0Z9GNevradR6SJvs2UJ1iKAXyN6j3YydsD9bfWI aHyrz6o/6uLVy5y4c+Ft3CnmQp3ouVhMHXaPRO+bncF2B/nXTnD3SOfnBouN2YZKgmwc +NaQhTSZQKWJ87XLXN599aUX0V6qMJwCk7ot3r2UwKT+zXp1LG+SbymwznOwZbF9IKLb Hy6VgSCZoaGCakCuBwqZTPf8rLRgwhCysmt4hb+9+48lWcUjk2cwFGVk7gvfcZYuPJe4 bh65V0hhyC2CISw+ijG0xIl3nLhWq64/4Elr3yd5CiRhyQpYbyjE3G6HalunCMgsnD/K UR+Q== X-Gm-Message-State: AOAM533sENRSvDo+qsfWvI7479amfXWGZC8/LUJ99N7Ws/k8QDmAtk/C E00Z9bHJHrnQpT+AUZQMed0+m3tnFrOFPQ== X-Google-Smtp-Source: ABdhPJxBs/qrqNz7Ldjs3z1PYFK4QzKyY5agPezJtdnXVLjxzQZP4klFnaJccBeowJFBoLD78rWt+Q== X-Received: by 2002:a2e:5807:: with SMTP id m7mr20404470ljb.25.1632729530016; Mon, 27 Sep 2021 00:58:50 -0700 (PDT) Received: from grain.localdomain ([5.18.253.97]) by smtp.gmail.com with ESMTPSA id z16sm1924626lji.41.2021.09.27.00.58.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 00:58:48 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 588345A001E; Mon, 27 Sep 2021 10:58:48 +0300 (MSK) Date: Mon, 27 Sep 2021 10:58:48 +0300 To: Serge Petrenko Cc: tml , Vladislav Shpilevoy Message-ID: References: <20210922130535.79479-1-gorcunov@gmail.com> <20210922130535.79479-5-gorcunov@gmail.com> <65ba334f-2d96-7db7-ca81-1b4ebfb3423b@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <65ba334f-2d96-7db7-ca81-1b4ebfb3423b@tarantool.org> User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH v17 4/5] qsync: export more details on promote tracking X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Mon, Sep 27, 2021 at 10:00:28AM +0300, Serge Petrenko wrote: > > > 22.09.2021 16:05, Cyrill Gorcunov пишет: > > The patch introduces `promote` leaf to `box.info.synchro` table. > > > > | tarantool> box.info.synchro > > | --- > > | - queue: > > | len: 0 > > | owner: 1 > > | quorum: 1 > > | promote: > > | term_max: 4 > > | term_map: {1: 4} > > | ... > > > > An idea is to be able to track changes of seen requests. Since it is > > internal implementation details I prefer to not document it. Actually > > better to mark is as non-API somehow. > > I think this info might be useful, so maybe document it as well? > > I'd call it `journal`, probably. > box.info.synchro.journal.term - what you call term_max > box.info.synchro.journal.term_map You know, I don't mind :) We need to choose "info" leaves and branches names very carefully though, because it becomes API. So I guess we could consider journal branch where we would gather not only synchro related information but extend output for debug/stat sake in future? box.info journal: synchro: (replication related info) term: 4 term_map: {1: 4} queue: (flush queue related info) len: 12 stat: wrote: 400 bytes I don't have strong opinion which form is better, I'm fine with any, just sharing an idea.