From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 865556FC86; Thu, 16 Sep 2021 13:50:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 865556FC86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1631789430; bh=o4SvqyiHtz0z9SzGdhjNAg+ek/TongXzYV+kSh7W7xE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=aHuwiSOezxjRfsZW5AAUA5CKJKzm7tlh8F0r+dsFzupZSABqB+Z3rr3QwxVet371R dGX2RwMo1Fhg3sP6JBBY8vCNpz3JbKudKQBFM+xNL0rNH3VCc2f0X6fbjGMssiNrBm QhqFo8BPTaQZ+1bTkVKPe9zUugRTn7SqABRG+fvw= Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 934A96FC86 for ; Thu, 16 Sep 2021 13:50:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 934A96FC86 Received: by mail-lf1-f48.google.com with SMTP id i7so16627635lfr.13 for ; Thu, 16 Sep 2021 03:50:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sEgyI6OuQOeP685pD9rrGjHJk8qBfIR+JPaAnZvqOK0=; b=yGYU/dQcZv8xSe/aLPDenxl2p9f3ixLgniqyD0XJQX2JPT47K3lYijkV620VxG15vQ 5pATz15Zal9BOqRdxob4i2I88IEg0Bt9ENFd9s9iJFRBjmiQowArr+zdYXcKcBbKCSti fuD4sgVNmNQeWelZqAlvjSxOdgwF6zyT0qwqc7LdH/wd+iBjlQ+bYFwNQGv/CmARTHXl hXrO1HQAONf5qvG47HvmXzMmoV2945kyz4soQc08ORMnOQFmQyFni2GQf7cEP/yYvwHd ND7OkiSJjU3bQqTeCjTQvGRoZYEpkeZ6AVh+s7O4xb48rPzsdYVQA/eS0cPFLvHuwP/C 8tIQ== X-Gm-Message-State: AOAM532Zvh5bsv3iZnhMg1pQ5rOOKhZxWCNiZ9hoN4QofzJ5+Lkwp+bu jrnbk3kD3BvURNqAd3TfRFYQFkeifT0BWQ== X-Google-Smtp-Source: ABdhPJxQg4iZX+cGEnFIR50nQxzb5Agf2zuJlHN43dGbmiuyeAb4K7FBeWCgCcZbX3Y40apJRHutJA== X-Received: by 2002:a05:6512:1112:: with SMTP id l18mr3510739lfg.124.1631789428403; Thu, 16 Sep 2021 03:50:28 -0700 (PDT) Received: from grain.localdomain ([5.18.253.97]) by smtp.gmail.com with ESMTPSA id d23sm226002lfv.245.2021.09.16.03.50.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Sep 2021 03:50:27 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id C0DF95A001E; Thu, 16 Sep 2021 13:50:26 +0300 (MSK) Date: Thu, 16 Sep 2021 13:50:26 +0300 To: Vladislav Shpilevoy Message-ID: References: <20210915145046.133303-1-gorcunov@gmail.com> <3d06cce4-3350-35fe-5655-450f91ab0678@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d06cce4-3350-35fe-5655-450f91ab0678@tarantool.org> User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH v16 0/3] qsync: implement packet filtering (part 1) X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, Sep 16, 2021 at 12:51:37AM +0200, Vladislav Shpilevoy wrote: > On 15.09.2021 16:50, Cyrill Gorcunov via Tarantool-patches wrote: > > Packet filtering takes more and more time to implement and I send > > similar patches again multiple times. Still the complete split brain > > detection is not yet done, so I thought it might be worth to split the > > work into several series. This part addresses a race with terms manipulation > > and I think can be considered as its own. > > > > I would really appreciate comments here mostly due to function naming, > > comments and etc. My primary aim was to make sure that this series doesn't > > break anything existing but I think if we would have a test case for this > > ordering issue it would be brilliant, though I didn't come with some simple > > one here yet. > > Committing a part of the series won't speed up the other patches, unfortunately. > If you think something can be done separately, it is a good idea. But still > such changes must be independent and have their own tests then. > > Just pushing some first commits won't help with the next ones. Could you please at least comment "function naming, comments in code and etc", so the lack of test would be the only issue.