From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 354546EC55; Thu, 29 Jul 2021 00:57:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 354546EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627509461; bh=ZTFDlwKsPL3buownUmug2mUAfgmrjc8sup1tndN8XHE=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ApKjS5Hgsxy0cL7rYBAUvR+BKDSDtIFmmfmFF87+bOM0Pewjrrs1lc7V3Qpvf884E 6WQdUD4ar+AyDhkqk28OO75B0RN9/Oa9X9Rfhm0RVkG6VwbtkHlHnN37NnzH1fhCnE trRrlgTPJa0BuY4i5IcM4L+M9//YpWYl/mxiQ1lg= Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 964026EC55 for ; Thu, 29 Jul 2021 00:57:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 964026EC55 Received: by mail-lj1-f174.google.com with SMTP id a7so4804645ljq.11 for ; Wed, 28 Jul 2021 14:57:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8dYWw37sVPFXr066L30ZwCxWZpeosvAWqqlnTb1UrUw=; b=O/8exIr470RkAAvdIUKTYDy87Cvsolum8Rx+fnGR5Gf7qPf4R7qscjkRcvyvEnt1h3 kTvY8xaq/0IBLs15K4xb7wqCIKK4UoVGcoeSlBLbZjw0pE8zWws+b8sah2lVt6nw+bjO tQnJD+/VND+GYaG0ykuuhJ8C+UnpjISprQkYJ0S+13OD7o9Fgi0Q5xwWWG+sKWI2z9Yg HEoNQXUQkPN2SritBRMnt9Z7r/D/IMMBZprMe1L5S8SA1wsixbEG8Ui5eVkX87bKku/3 EGuBHf18czI5vhjvzi5d5Qc3iQj/k3lx8g9BQsNbYLr6zWBpr0Pqt51a5q76U9M0zrBS zgzQ== X-Gm-Message-State: AOAM532nBJhZKnW7MKWcnGB+I+W76HR2UVWBoYF+UQ4F8TeWARYqyIsa 7tQgWCswMqFJTngzgEu3AaRwPrwVeje2lg== X-Google-Smtp-Source: ABdhPJynSIuJWnwEgXCV8yYF0HO246js2nMdASgSN7aMhp0bclQDBU2O1r15O5W9xYI0XL3Q8Pr69A== X-Received: by 2002:a2e:5307:: with SMTP id h7mr1087051ljb.181.1627509458436; Wed, 28 Jul 2021 14:57:38 -0700 (PDT) Received: from grain.localdomain ([5.18.255.97]) by smtp.gmail.com with ESMTPSA id c6sm109724lfp.196.2021.07.28.14.57.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jul 2021 14:57:37 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 8DC2A5A001E; Thu, 29 Jul 2021 00:57:36 +0300 (MSK) Date: Thu, 29 Jul 2021 00:57:36 +0300 To: Vladislav Shpilevoy Cc: tml Message-ID: References: <20210726153452.113897-1-gorcunov@gmail.com> <20210726153452.113897-4-gorcunov@gmail.com> <3a64d0ce-b2aa-d331-942e-b60484638dd9@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3a64d0ce-b2aa-d331-942e-b60484638dd9@tarantool.org> User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH v8 3/6] limbo: gather promote tracking into a separate structure X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Wed, Jul 28, 2021 at 11:34:43PM +0200, Vladislav Shpilevoy wrote: > Hi! Thanks for the patch! > > On 26.07.2021 17:34, Cyrill Gorcunov via Tarantool-patches wrote: > > It is needed to introduce ordered promote related data > > modifications in next patch. > > Why do you need this new struct? While I like the new names > (the old promote_greatest_term was super long), I don't see > any motivation to extract the members into a new struct. > It is still used only inside of the limbo as a member. > > I suppose this might be a leftover from the old versions of > the patchset. Please, try to keep these members inside of > the limbo like they were. The key moment here is the locking we use for terms tracking, note the locking is not covering the whole limbo thus better to keep the lock itself inside the structure it protects I think. Cyrill