From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 199806EC55; Wed, 28 Jul 2021 21:49:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 199806EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627498195; bh=/WDEVY3ey3RMgmwo/6ZSzs5ZSjkpEd7ICyGkQUKvbec=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Dgzk71MfWiXPwS5p4UpC8x/9Prm3NPtq5h/UsQUexDWaRoC28w0TOIfb//EhgM7A4 hF4rvu6jrdBIHmyAvrPfImGjPIVpA7ftIyRd6GY33hZzvBiSTxZqKsljxbQC4s/ATW /xTCJdAu4ZYgC2itErJrtz+1H4tatXsTT5BceYiU= Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [94.100.177.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BC47C6EC55 for ; Wed, 28 Jul 2021 21:49:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BC47C6EC55 Received: by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1m8ocq-0007WO-Nw; Wed, 28 Jul 2021 21:49:53 +0300 Date: Wed, 28 Jul 2021 21:48:40 +0300 To: =?utf-8?B?0JzQsNC60YHQuNC8INCa0L7RgNGP0LrRiNC40L0=?= Message-ID: References: <72be0416bbad48dca0240fbb8046ee5e6e596227.1626797225.git.m.kokryashkin@tarantool.org> <20210725211450.GK27855@tarantool.org> <1627302069.737903818@f348.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1627302069.737903818@f348.i.mail.ru> X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C33D83595CA30D6DC5179D1C9A908C47E5182A05F538085040435CB8D8EC95CA92FA4958FE1D881350566B9D5B543D36AE006EC9AB7CB3411E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DB84ED444C624799EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E8F1A1743CF948808638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D837E09FD8110072948C4105F90639D8D7117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B2EE5AD8F952D28FBA471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C468D16C903838CAB43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A505100073E7CAAD2CC26DE7A0B49C588FFF3348DF2FD2A454D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA754263BA4E959D734C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F05B761BB9C2AA447A05BEABB49248D477A4382C53970476E77476C1B77013289EEF302650711AE31D7E09C32AA3244CBFA8EA6608071AD3296063CAC3308C3EE8FBBEFAE1C4874CFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiF1u9eOpfTSXba00MGu/cw== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4538DB004BFCA885EF2FA38FB515039409407EAEEDB6DACBAF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 09/10] test: update lua-Harness to b7b1a9a2 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! LGTM, except a single nitpick regarding the commit message. On 26.07.21, Максим Корякшин wrote: > > Thanks for the review, Igor! > New commit message, considering your suggestions: > ============================================================= >     test: update lua-Harness to c4451fe >   >     This patch backports several small commits from lua-Harness suite: Typo: s/from lua-Harness suite/from the lua-Harness suite/ >     - follow ravi 1.0-beta4[1] >     - refactor with near[2] >     - follow LuaJIT[3] >     - fix when no debug[4] >     - check if luac exists[5] >     - https[6] >     - more assert[7] >   >     [1]: https://framagit.org/fperrad/lua-Harness/-/commit/9455281b >     [2]: https://framagit.org/fperrad/lua-Harness/-/commit/70404580 >     [3]: https://framagit.org/fperrad/lua-Harness/-/commit/ac7671b6 >     [4]: https://framagit.org/fperrad/lua-Harness/-/commit/4db7e539 >     [5]: https://framagit.org/fperrad/lua-Harness/-/commit/97e9e4c1 >     [6]: https://framagit.org/fperrad/lua-Harness/-/commit/673c7869 >     [7]: https://framagit.org/fperrad/lua-Harness/-/commit/b7b1a9a2 >   >     Part of tarantool/tarantool#5970 >     Part of tarantool/tarantool#4473 >   > ============================================================= >   > And here is the diff, which will add missing changes: > ============================================================= > diff --git a/test/lua-Harness-tests/301-basic.t b/test/lua-Harness-tests/301-basic.t > index 4adbb55c..e4ed2c41 100755 > --- a/test/lua-Harness-tests/301-basic.t > +++ b/test/lua-Harness-tests/301-basic.t > @@ -53,13 +53,15 @@ local lua = _retrieve_progname() >  plan'no_plan' >  do -- assert > -    local v, msg = assert('text', "assert string") > +    local v, msg, extra = assert('text', "assert string", 'extra') >      equals(v, 'text', "function assert") >      equals(msg, "assert string") > -    v, msg = assert({}, "assert table") > +    equals(extra, 'extra') > +    v, msg, extra = assert({}, "assert table", 'extra') >      equals(msg, "assert table") > +    equals(extra, 'extra') > -    error_matches(function () assert(false, "ASSERTION TEST") end, > +    error_matches(function () assert(false, "ASSERTION TEST", 'extra') end, >              "^[^:]+:%d+: ASSERTION TEST", >              "function assert(false, msg)") > @@ -73,7 +75,7 @@ do -- assert >      else >          error_matches(function () assert(false, 42) end, >                  "^[^:]+:%d+: 42", > -                "function assert(false, 42)") > +                "function assert(false, 42) --> invalid") >      end >      if has_error53 then > ============================================================= >   >   >     > >Max, > > > >Thanks for the patch! Please consider the comments below. > > > >On 20.07.21, Maxim Kokryashkin wrote: > >> This patch backports several small commits from lua-Harness suite: > >> - follow ravi 1.0-beta4[1] > >> - refactor with near[2] > >> - follow LuaJIT[3] > >> - fix when no debug[4] > >> - check if luac exists[5] > >> - https[6] > >> - more assert[7] > >> > >> [1]: https://framagit.org/fperrad/lua-Harness/-/commit/9455281b > >> [2]: https://framagit.org/fperrad/lua-Harness/-/commit/70404580 > >> [3]: https://framagit.org/fperrad/lua-Harness/-/commit/ac7671b6 > >> [4]: https://framagit.org/fperrad/lua-Harness/-/commit/4db7e539 > >> [5]: https://framagit.org/fperrad/lua-Harness/-/commit/97e9e4c1 > >> [6]: https://framagit.org/fperrad/lua-Harness/-/commit/673c7869 > >> [7]: https://framagit.org/fperrad/lua-Harness/-/commit/b7b1a9a2 > > > >The changes from the latter commit is missing. > > > >Furthermore, you've updated lua-Harness up to c4451fe, which is > >backported in scope of "[PATCH v2 01/10] test: port lua-Harness to > >Test.Assertion". Hence, the commit subject need to be updated too. > > > >> > >> Part of #5970 > >> Part of #4473 > > > >BTW, both issues are also mentioned the wrong way. The right format is > >tarantool/tarantool# for both cases (see the previous > >patches in the series for the examples). > > > >> --- > >> test/lua-Harness-tests/200-examples.t | 2 +- > >> test/lua-Harness-tests/203-lexico.t | 2 +- > >> test/lua-Harness-tests/241-standalone.t | 3 +- > >> test/lua-Harness-tests/242-luac.t | 4 +++ > >> test/lua-Harness-tests/301-basic.t | 2 +- > >> test/lua-Harness-tests/304-string.t | 2 +- > >> test/lua-Harness-tests/307-math.t | 44 +++++++++++------------ > >> test/lua-Harness-tests/310-debug.t | 2 -- > >> test/lua-Harness-tests/320-stdin.t | 14 +++++--- > >> test/lua-Harness-tests/401-bitop.t | 2 +- > >> test/lua-Harness-tests/402-ffi.t | 2 +- > >> test/lua-Harness-tests/403-jit.t | 2 +- > >> test/lua-Harness-tests/404-ext.t | 2 +- > >> test/lua-Harness-tests/411-luajit.t | 2 +- > >> test/lua-Harness-tests/profile_ravi.lua | 4 +-- > >> test/lua-Harness-tests/test_assertion.lua | 9 +++++ > >> 16 files changed, 57 insertions(+), 41 deletions(-) > >> > > > > > > > >> -- > >> 2.32.0 > >> > > > >-- > >Best regards, > >IM >   -- Best regards, Sergey Kaplun