From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 714A26EC55; Wed, 28 Jul 2021 21:51:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 714A26EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627498292; bh=jEMVwqfkI8tc3q1O1bP58UCSSbjHG+OIuF7po4Tvn4Q=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=NN+2gYSEZmA4wzP2Ywhi0cQTbrQCGOcTmBzraWLWfJDx1QLb4/+FmQ2/Z3HcITB38 qTpPmYHiL5vjMG6YF5wx4p9KKooHUwRuT2IhXpv8k2N/4wbzpocDaXWvcW2tieVDEd c0/9lvNs+/w9W5VHFLLu9ZsZ6FG1m6lOyUVIZj4Y= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A15FD6EC55 for ; Wed, 28 Jul 2021 21:51:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A15FD6EC55 Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1m8oeQ-00089X-0t; Wed, 28 Jul 2021 21:51:30 +0300 Date: Wed, 28 Jul 2021 21:50:18 +0300 To: =?utf-8?B?0JzQsNC60YHQuNC8INCa0L7RgNGP0LrRiNC40L0=?= , tarantool-patches@dev.tarantool.org Message-ID: References: <39f288e9c6c4722433599ab33371ecd2470f1125.1626797225.git.m.kokryashkin@tarantool.org> <20210725211327.GJ27855@tarantool.org> <1627298220.392923948@f312.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD941C43E597735A9C34755E0A9F196FCB739C645213AB7C8E0182A05F538085040385645C9E68E0F368DE41897415CA52CA159CACB47F20184A6AA412F1A7700D9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE789066434B85BF7C7EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F5B2F26146BDF5648638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C532CECB1D77CA7662E6A9D615F18E4A117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B613439FA09F3DCB32089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B5051C383417B29BAA95ADED1EFB62546FDB X-C1DE0DAB: 0D63561A33F958A5F1B6D1B8B7D8A9725276492348395991AD639258B582DF9FD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA754263BA4E959D734C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D346B71C4B0698719D7896CA73E305EAA734D663503A03391ACC3294C5D33D39C3DCDDC03A9394B10451D7E09C32AA3244CF10E43A97F7A5BD1C3F55996D613E298BBA718C7E6A9E042729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiF1u9eOpfTT5Gn7wgbtfUw== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4E99D81BD131BCA831AFDF4BEEC1ECC6546EB8B20CC5C2CB7F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 08/10] test: support tarantool cli in lua-Harness X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 28.07.21, Sergey Kaplun via Tarantool-patches wrote: > Hi, Maxim! > > Thanks for the patch and fixes! > > LGTM, except a few nits regarding to the commit message. > > On 26.07.21, Максим Корякшин wrote: > > > > Thanks for the review, Igor! > > Here is the new commit message, considering your comments: > > ================================================= > >     test: support tarantool cli in lua-Harness > >   > >     The patch[1] from lua-Harness suite adjusts some checks in > > Typo: s/from lua-Harness suite/the from lua-Harness suite/ Brr, typo in typo: "from the lua-Harness suite", of course. > > >     lua-Harness tests, so they are compatible with Tarantool now. > >   > >     As a result, the introduced assertion for Tarantool error message fails > >     on MacOS, since getopt_long(3) yields the error message without single > >     quotes wrapping the flag. Hence, this commit also includes fix for that > > Typo: s/fix/the fix/ > > >     from patch[2] in the trunk. > > Typo: s/patch/the patch/ > > >   > >     [1]: https://framagit.org/fperrad/lua-Harness/-/commit/1da5b1b > >     [2]: https://framagit.org/fperrad/lua-Harness/-/commit/a0532c5 > >   > >     Part of tarantool/tarantool#5970 > >     Part of tarantool/tarantool#4473 > >   > > ================================================= -- Best regards, Sergey Kaplun