From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 842586EC55; Wed, 28 Jul 2021 21:35:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 842586EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627497348; bh=Ztanz/d6+cxWtcoUSIgSwowo5UD1o7CqTGyTMpI+Umw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=sNPB1ZBo3YA1Jk3U5sAE7m5GbEWwyF2GrllUsm5s+ZhKC59FAGyaxuoC1EWNbTVle ni/xK1kKNjTP8DormRDSBMKCPHyp8znvezxVM1idBXQ0yNZc38k7x7cu1P3zKUOFdJ azlEj9iiSr+/7ldXRoOYUnVnROBYiCmVfKgorp30= Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 404F96EC55 for ; Wed, 28 Jul 2021 21:35:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 404F96EC55 Received: by smtp46.i.mail.ru with esmtpa (envelope-from ) id 1m8oPC-0001mH-Bk; Wed, 28 Jul 2021 21:35:46 +0300 Date: Wed, 28 Jul 2021 21:34:33 +0300 To: =?utf-8?B?0JzQsNC60YHQuNC8INCa0L7RgNGP0LrRiNC40L0=?= Message-ID: References: <3c7f4b9f754b86daaa59bc6663fb8235d4ee7e56.1626797225.git.m.kokryashkin@tarantool.org> <1627494133.365921222@f190.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1627494133.365921222@f190.i.mail.ru> X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C33D83595CA30D6DC5179D1C9A908C47E5182A05F5380850400AFEC12D86E48852606BD3685492BFD930537EA5B3A4A3EAA31BB8EA67301205 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76ABD3380F320B62CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637ED2BA022FBF94AB68638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D85E7F83174F3D146537596A4DFD6FF235117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A58FAA3EBCF368C21C87146F11362B09EE3DFA741857BB86A2D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA754263BA4E959D734C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3455AC8BF8E3153BA0E479AEB1399E8B9C1CF232AC547C23D88D9DD7398E21D8BF82ACF8898DA7002C1D7E09C32AA3244C86FD25BA5FE403C0760AE9DDD402E012259227199D06760A927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiF1u9eOpfTQt/91pCbAOdQ== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB46EA22020A2163C6E8C1C75224B0E2CA2557681D80CE42DD6F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 06/10] test: support tarantool in lua-Harness X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the fixes! My bad, didn't check it before: When building out-of-source build and run tests, 411 test still failed, because LUA_PATH doesn't include path to generated . Please add path to it in the . | module 'jit.vmdef' not found: | no field package.preload['jit.vmdef'] | no file './jit/vmdef.lua' | no file '/home/burii/reviews/luajit/harness/test/lua-Harness-tests/jit/vmdef.lua' | no file '/home/burii/reviews/luajit/harness/src/jit/vmdef.lua' | no file './jit/vmdef.so' | no file '/usr/local/lib/lua/5.1/jit/vmdef.so' | no file '/usr/local/lib/lua/5.1/loadall.so' | no file './jit.so' | no file '/usr/local/lib/lua/5.1/jit.so' | no file '/usr/local/lib/lua/5.1/loadall.so' On 28.07.21, Максим Корякшин wrote: > > Here is the new commit message: > ================================================================================== > ================================================================================== >   > And the diff with LUA_PATH adjustments: > ================================================================================== > diff --git a/test/lua-Harness-tests/CMakeLists.txt b/test/lua-Harness-tests/CMakeLists.txt > index b9804033..bd7f4a9c 100644 > --- a/test/lua-Harness-tests/CMakeLists.txt > +++ b/test/lua-Harness-tests/CMakeLists.txt > @@ -13,7 +13,7 @@ endif() >  # Tests create temporary files (see 303-package.t for example) >  # to require. Also, they require some files from original >  # test source directory. Nit: Also you may adjust those comment about required files. > -set(LUA_PATH "./?.lua\;${CMAKE_CURRENT_SOURCE_DIR}/?.lua\;") > +set(LUA_PATH "./?.lua\;${CMAKE_CURRENT_SOURCE_DIR}/?.lua\;${LUAJIT_SOURCE_DIR}/?.lua") >  set(LUA_TEST_FLAGS --failures --shuffle) >   >  if(CMAKE_VERBOSE_MAKEFILE) > =================================================================================== >   >   > -- > Максим Корякшин >   >   > >Вторник, 27 июля 2021, 13:05 +03:00 от Sergey Kaplun : > >  > >Hi, Maxim! > > > >Thanks for the patch! > > > >Please consider my comments below. > > > >On 20.07.21, Maxim Kokryashkin wrote: > >> Backports 'supoort Tarantool' patch[1] from lua-Harness. > >> > >> [1]: https://framagit.org/fperrad/lua-Harness/-/commit/d3ceee16 > >> > >> Part of tarantool/tarantool#5970 > >> Part of tarantool/tarantool#4473 > >> --- > > > >| test: support tarantool in lua-Harness > > > >Nit: s/tarantool/Tarantool/. > > > >| > >| Backports 'support Tarantool' patch[1] from lua-Harness. > > > >Nit: s/Tarantool/tarantool/ regarding to the original commit message. > > > >| This patch introduces lua-Harness profile for Tarantool considering the > >| platform specifics. Furthermore, these changes skip all CLI-related > >| tests for Tarantool binary, so 241-standalone.t and 411-luajit.t can be > >| renamed back. > > > >I afraid, not so fast. Within these changes tests are failed in the > >LuaJIT's repo with the following error: > >|! unknown luaJIT command or jit.* modules not installed > > > >Seems like LUA_PATH should be adjusted for these tests. > >| > >| [1]: https://framagit.org/fperrad/lua-Harness/-/commit/d3ceee16 > >| > >| Part of tarantool/tarantool#5970 > >| Part of tarantool/tarantool#4473 > > > >> ...standalone.t.disabled => 241-standalone.t} | 5 ++ > >> test/lua-Harness-tests/320-stdin.t | 2 +- > >> .../{411-luajit.t.disabled => 411-luajit.t} | 2 +- > >> test/lua-Harness-tests/profile_tarantool.lua | 63 +++++++++++++++++++ > >> 4 files changed, 70 insertions(+), 2 deletions(-) > >> rename test/lua-Harness-tests/{241-standalone.t.disabled => 241-standalone.t} (99%) > >> rename test/lua-Harness-tests/{411-luajit.t.disabled => 411-luajit.t} (99%) > >> create mode 100644 test/lua-Harness-tests/profile_tarantool.lua > > > > > > > >-- > >Best regards, > >Sergey Kaplun >   -- Best regards, Sergey Kaplun