From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 56A546EC55; Thu, 15 Jul 2021 15:20:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 56A546EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1626351614; bh=F69uGQKrb+e71ruwxyRjCqZg+vi/UnD9NwlC4gL+Nok=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=UJI7/68gm1OSCcnmBkXXYah0sXIDDvk1A4dpY8hFY5x/Sd8zorD6BScLe1LKZ9kjd +3yTbl8vA29UQ3CivzzRGhep0XHgMwsKtqTMkW3UspMhOp16Sq1ou0j4FpGnetwejk DWk1e8RgdKk12XY1X98sHx6xUaYfVAriIbm39Mjs= Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 976E06EC55 for ; Thu, 15 Jul 2021 15:20:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 976E06EC55 Received: by mail-lf1-f44.google.com with SMTP id 22so9432601lfy.12 for ; Thu, 15 Jul 2021 05:20:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sKcCzcHEXg37TmoihLD3g3eTId4N9g+Ef+E9o1tLI0g=; b=exQI9VvsqNJAQ7zMtu2IM41zA8UMGIYF04o0942EVEOhL8lrwgC+00GXkBDrhu60yM YwpXFigJ/92pAACcD5CTpJrHCVV8Y70mo6FNKwkFh6H+sDC+WadCBD4Bh5QXsrDZCwOl ptecMbz8I5bee9yoJNgDWCxht69tWKSfNv1j6pRJ0pp0xflcKDYLB/NxgsGCqjjBJ5qi MLEODREkxwpEt8EJduLAPN50Q6vI4P49PAJ0mkrn+iUeQXkmQd9+VsoETGzmArA7H3h6 DSygBwHKO0mKpHYVdX7LbgaICz1/e5RuUtRMMg2KckcywNrXyOtF3dcPnM+OoyMEmG7Z B+xQ== X-Gm-Message-State: AOAM530yRvspfRaUjmtNIMVjJE3D4lSz67iRu+vm3W+dhnvvKucjttzf IexTaXADZMVd+A5dmQw1wif8TvDtemO2IA== X-Google-Smtp-Source: ABdhPJzI55NRTySF9u6QPvcwGqqDQ0yHDcAddLy/9RyGY429MCsNjhOcmbEulaG+s4S+QSDjFpHasw== X-Received: by 2002:a19:434c:: with SMTP id m12mr3278540lfj.45.1626351612620; Thu, 15 Jul 2021 05:20:12 -0700 (PDT) Received: from grain.localdomain ([5.18.255.97]) by smtp.gmail.com with ESMTPSA id k11sm402130lfm.133.2021.07.15.05.20.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jul 2021 05:20:11 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 4B8BD5A001E; Thu, 15 Jul 2021 15:20:10 +0300 (MSK) Date: Thu, 15 Jul 2021 15:20:10 +0300 To: Serge Petrenko Cc: tml , Vladislav Shpilevoy Message-ID: References: <20210714212328.701280-1-gorcunov@gmail.com> <20210714212328.701280-5-gorcunov@gmail.com> <5e43c72a-b837-2437-4e8c-e7ef739f0476@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e43c72a-b837-2437-4e8c-e7ef739f0476@tarantool.org> User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [RFC v5 4/5] limbo: order access to the promote terms X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, Jul 15, 2021 at 02:48:48PM +0300, Serge Petrenko wrote: > > I think all panic_on(!cond) invocations may be replaced with assert(cond) > > Even if we use some functions incorrectly, this may be catched by an > assertion. You know, initially I thought of using assert as well but then realized that our test's coverage is far from being perfect so that if we manage to miss locking, the results are really awfull - data become inconsistent as far as I understand. So I would prefer to have panic_on here. But if you still prefer assert then sure, I'll drop panic_on.