From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 63F986EC55; Tue, 27 Jul 2021 09:22:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 63F986EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627366957; bh=+jzZFpiJND3zwChkUoVBUERTArj/yu82zadD9Ijq0Zk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ifuxVXzCsblxREJ8BeY4J24FIq2vMeM9/B9bzOW5CuqMLVxL953mn8+VCK1fMjuJ8 I7fzF4aHzDkKm96mVk/FB2gsosPHddLSS+U+mpl64daI+lBdOUui4/sFlxrbbh/C1W UkyxJ4Uv+2mUO8J4v4sO8CZjEFVKYMMh0T3W19No= Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8179C6EC55 for ; Tue, 27 Jul 2021 09:22:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8179C6EC55 Received: by smtp46.i.mail.ru with esmtpa (envelope-from ) id 1m8GU7-0004ZV-HA; Tue, 27 Jul 2021 09:22:35 +0300 Date: Tue, 27 Jul 2021 09:21:24 +0300 To: =?utf-8?B?0JzQsNC60YHQuNC8INCa0L7RgNGP0LrRiNC40L0=?= Message-ID: References: <1627302676.27157197@f710.i.mail.ru> <1627302729.534847627@f710.i.mail.ru> <1627302979.755910918@f710.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1627302979.755910918@f710.i.mail.ru> X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD941C43E597735A9C34755E0A9F196FCB739C645213AB7C8E0182A05F53808504010BC3FC50DE09F2851D5464A2FC1580D20577ECBFD89764B0A1C3CB38705C3E1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A3DED2DACB82E709C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE768D1C4AD116E0413EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F2561FAA07F71D16897BF811F6A7B51DD2CC7F00164DA146DAFE8445B8C89999728AA50765F7900637DCE3DBD6F8E38AFD389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8744B801E316CB65FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B08F9A42B2210255C75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A50D68CDED0E3ABC970ECB1EAA065F071CED032EBEEC5320CBD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7536C62C4FBC402878410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D4140D813EC137C69C90B23C726AC13DA35DC38032F1CDF11D37397B4DF0C923099DE11112AF3A5B1D7E09C32AA3244C3F3D0FADC8F13B4D0933CAC51E23354AA90944CA99CF22E3FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMEANdStWW59SwQEVTUa+7Q== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB42981D22C4C089851546E21D9E37C7064F7B91FE06A480687F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 10/10] test: disable test/lua-Harness-tests/241-standalone.t on FreeBSD X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! LGTM, except a few nits below. On 26.07.21, Максим Корякшин wrote: > > Sorry for the several emails, I have encountered some issues with the email client. >   > Anyway, here is the diff, that masks only one particular assertion instead of masking all of them: > ======================================================================== > diff --git a/test/lua-Harness-tests/241-standalone.t b/test/lua-Harness-tests/241-standalone.t > index d5373b9f..bdd95514 100755 > --- a/test/lua-Harness-tests/241-standalone.t > +++ b/test/lua-Harness-tests/241-standalone.t > @@ -51,10 +51,6 @@ if not pcall(io.popen, lua .. [[ -e "a=1"]]) then >      skip_all "io.popen not supported" >  end > -if jit.os == 'BSD' then > -    skip_all "BSD is not supported yet" > -end > - >  plan'no_plan' >  diag(lua) > @@ -116,22 +112,24 @@ f = io.popen(cmd) >  equals(f:read'*l', 'Hello World', "redirect") >  f:close() > -cmd = lua .. " -i hello-241.lua < hello-241.lua 2>&1" > -f = io.popen(cmd) > -matches(f:read'*l', banner, "-i") > -if ujit then > -    matches(f:read'*l', '^JIT:') > -end > -if ravi then > -    matches(f:read'*l', '^Copyright %(C%)') > -    matches(f:read'*l', '^Portions Copyright %(C%)') > -    matches(f:read'*l', '^Options') > -end > -if _TARANTOOL then > -    matches(f:read'*l', "^type 'help' for interactive help") > +if jit.os ~= 'BSD' then Nit: Feel free to drop a comment here why this part is disabled for FreeBSD (maybe with FIXME or XXX label). > +    cmd = lua .. " -i hello-241.lua < hello-241.lua 2>&1" > +    f = io.popen(cmd) > +    matches(f:read'*l', banner, "-i") > +    if ujit then > +        matches(f:read'*l', '^JIT:') > +    end > +    if ravi then > +        matches(f:read'*l', '^Copyright %(C%)') > +        matches(f:read'*l', '^Portions Copyright %(C%)') > +        matches(f:read'*l', '^Options') > +    end > +    if _TARANTOOL then > +        matches(f:read'*l', "^type 'help' for interactive help") > +    end > +    equals(f:read'*l', 'Hello World') > +    f:close() >  end > -equals(f:read'*l', 'Hello World') > -f:close() >  cmd = lua .. [[ -e"a=1" -e "print(a)"]] >  f = io.popen(cmd) > ======================================================================== >   > And here is the fixed commit message: > ======================================================================== >     test: disable 241-standalone.t on FreeBSD Nit: Strictly saying the patch disables only interactive mode part with input from the file. >   >     Tarantool interactive mode misbehaviour has been found on >     FreeBSD (for more info see tarantool/tarantool#6231). Hence, this[1] >     particular assertion is masked for FreeBSD until the mentioned issue >     resolves. >   >     [1]: https://framagit.org/fperrad/lua-Harness/-/blob/master/test_lua/241-standalone.t#L115-130 >   >     Part of tarantool/tarantool#5970 >     Part of tarantool/tarantool#4473 >     Relates to tarantool/tarantool#6231 >   > ======================================================================== >   > >Понедельник, 26 июля 2021, 15:32 +03:00 от Максим Корякшин : > >  > >diff: > >  > >  > >>  > >>>Max, > >>> > >>>Thanks for the patch! Please consider the comments below. > >>> > >>>At first, commit subject exceeds 50 symbols and the message exceeds 72 > >>>symbols. Please check this patch against our guidelines[1]. > >>> > >>>On 20.07.21, Maxim Kokryashkin wrote: > >>>> Tarantool interactive mode misbehaviour has been found on FreeBSD (for more info see #6231). > >>> > >>>The issue is mentioned the wrong way. The right format is > >>>tarantool/tarantool#6231. > >>> > >>>> Hence, this particular assertion is masked for FreeBSD until the mentioned issue resolves. > >>> > >>>Strictly saying, you skipped all assertions (not only those using broken > >>>interactive mode), not the particular one. > >>> > >>>> > >>>> Resolves #5970 > >>> > >>>This patch doesn't resolve the issue, since Tarantool profile introduced > >>>in "[PATCH v2 06/10] test: support tarantool in lua-Harness" is not used > >>>by Tarantool CI. Hence this is only "Part of" patch. > >>> > >>>> Part of #4473 > >>> > >>>BTW, both issues are also mentioned the wrong way. The right format is > >>>tarantool/tarantool# for both cases (see the previous > >>>patches in the series for the examples). > >>> > >>>It's also worth to add "Relates to tarantool/tarantool#6231". > >>> > >>>> --- > >>>> Additional info: https://github.com/tarantool/tarantool/issues/5970#issuecomment-883253400 > >>>> > >>>> test/lua-Harness-tests/241-standalone.t | 4 ++++ > >>>> 1 file changed, 4 insertions(+) > >>>> > >>>> diff --git a/test/lua-Harness-tests/241-standalone.t b/test/lua-Harness-tests/241-standalone.t > >>>> index afbcf5b8..d5373b9f 100755 > >>>> --- a/test/lua-Harness-tests/241-standalone.t > >>>> +++ b/test/lua-Harness-tests/241-standalone.t > >>>> @@ -51,6 +51,10 @@ if not pcall(io.popen, lua .. [[ -e "a=1"]]) then > >>>> skip_all "io.popen not supported" > >>>> end > >>>> > >>>> +if jit.os == 'BSD' then > >>>> + skip_all "BSD is not supported yet" > >>>> +end > >>> > >>>At first, please add a comment with the rationale for this change. > >>>Furthermore, it's better to skip only assertions using interactive mode > >>>and run other assertions related to CLI behaviour. > >>> > >>>> + > >>>> plan'no_plan' > >>>> diag(lua) > >>>> > >>>> -- > >>>> 2.32.0 > >>>> > >>> > >>>[1]: https://www.tarantool.io/en/doc/latest/dev_guide/developer_guidelines/ > >>> > >>>-- > >>>Best regards, > >>>IM > >>  > >  >   -- Best regards, Sergey Kaplun