From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id EC5106EC55; Tue, 27 Jul 2021 13:05:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EC5106EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627380328; bh=pk238MHrB3ewBsjP5ym/5CkxjswXdQxy5F0H/xh8W4o=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=jO1HQ/gJdAtDn3qwRXgxnULMS6OjJj3sBZnhEooRJiEWqt+GQUvgJtaPvAqZRS/Lh LeGtOgUlDHfsD0ZUjfX2MmKyjDZNO+bEKAl8SpVx3e522oeESITJogimPk61H+ab6i 4bVcn67IQnYGzukzlbs2M5KMcsheB/yuMccxRCSA= Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5AA186EC55 for ; Tue, 27 Jul 2021 13:05:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5AA186EC55 Received: by smtp40.i.mail.ru with esmtpa (envelope-from ) id 1m8Jxl-0002ce-Hv; Tue, 27 Jul 2021 13:05:25 +0300 Date: Tue, 27 Jul 2021 13:04:14 +0300 To: Maxim Kokryashkin Message-ID: References: <3c7f4b9f754b86daaa59bc6663fb8235d4ee7e56.1626797225.git.m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3c7f4b9f754b86daaa59bc6663fb8235d4ee7e56.1626797225.git.m.kokryashkin@tarantool.org> X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C33D83595CA30D6DC5179D1C9A908C47E5182A05F538085040BEB2C843C1C041460596C789B442B323290148E94F8ADF9EE3FAB7135B25260B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78CB87876C5D626D4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D7F1BE85E7B0CA818638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D868DE53BFA1F78359CE3C549D54873808117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18BDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B65D56369A3576CBA5089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A59EC1F3CCE476E31AD40A9684DF2AAC61D4897AE3B9C849FAD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75FA7FF33AA1A4D21C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34181D1E89D5A0B42F72CCCF81FE77053FB399890180496E9EBACD702984DC99F59D1ACB721393C27E1D7E09C32AA3244CE12E5552A84841AF1A78E478261ECA9D60759606DA2E136A927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMEANdStWW58qlODrQ/XR5Q== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB409C039185F8A3B890D4393B4DFE2035CCA3B0B4831EE0400F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 06/10] test: support tarantool in lua-Harness X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the patch! Please consider my comments below. On 20.07.21, Maxim Kokryashkin wrote: > Backports 'supoort Tarantool' patch[1] from lua-Harness. > > [1]: https://framagit.org/fperrad/lua-Harness/-/commit/d3ceee16 > > Part of tarantool/tarantool#5970 > Part of tarantool/tarantool#4473 > --- | test: support tarantool in lua-Harness Nit: s/tarantool/Tarantool/. | | Backports 'support Tarantool' patch[1] from lua-Harness. Nit: s/Tarantool/tarantool/ regarding to the original commit message. | This patch introduces lua-Harness profile for Tarantool considering the | platform specifics. Furthermore, these changes skip all CLI-related | tests for Tarantool binary, so 241-standalone.t and 411-luajit.t can be | renamed back. I afraid, not so fast. Within these changes tests are failed in the LuaJIT's repo with the following error: |! unknown luaJIT command or jit.* modules not installed Seems like LUA_PATH should be adjusted for these tests. | | [1]: https://framagit.org/fperrad/lua-Harness/-/commit/d3ceee16 | | Part of tarantool/tarantool#5970 | Part of tarantool/tarantool#4473 > ...standalone.t.disabled => 241-standalone.t} | 5 ++ > test/lua-Harness-tests/320-stdin.t | 2 +- > .../{411-luajit.t.disabled => 411-luajit.t} | 2 +- > test/lua-Harness-tests/profile_tarantool.lua | 63 +++++++++++++++++++ > 4 files changed, 70 insertions(+), 2 deletions(-) > rename test/lua-Harness-tests/{241-standalone.t.disabled => 241-standalone.t} (99%) > rename test/lua-Harness-tests/{411-luajit.t.disabled => 411-luajit.t} (99%) > create mode 100644 test/lua-Harness-tests/profile_tarantool.lua -- Best regards, Sergey Kaplun