From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B87D86EC55; Tue, 27 Jul 2021 12:36:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B87D86EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627378566; bh=xy133vCSgDWicYKPnNfv5l6GS70kSl0hN24KD5cKD5Q=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=VMwwfn3dHxwyd7Pmc7j+1wS/ThRPSSOgAdbFTy/4LV1fHt0r07WFDCciME7qDYiRd z7I2NUGn++pJ2XtG7QRo/mvukW3HzWo3Z5ybG3R90xS9eOxJ9sCGRs5KjVE7AEuDRJ LnVvAA4ujxiuJS2u6jDkYSf6+F4mH2DxhLJo5c5o= Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4C1D16EC55 for ; Tue, 27 Jul 2021 12:36:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4C1D16EC55 Received: by smtp55.i.mail.ru with esmtpa (envelope-from ) id 1m8JVN-0001qS-Eo; Tue, 27 Jul 2021 12:36:05 +0300 Date: Tue, 27 Jul 2021 12:34:53 +0300 To: =?utf-8?B?0JzQsNC60YHQuNC8INCa0L7RgNGP0LrRiNC40L0=?= Message-ID: References: <34c2c2f332776613a3fd456ea62d00e892ad6369.1626797225.git.m.kokryashkin@tarantool.org> <20210725211051.GG27855@tarantool.org> <1627301484.354783941@f339.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1627301484.354783941@f339.i.mail.ru> X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C3038391AAE5FBFA7682283CBB09BF492D182A05F538085040ACC5D27B192C295B4FDC956E4246B4A37DC559FA18EC098E3E8781B3194311D0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE742D9BD90C58D50E0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372CAA106849E7D531EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F25B0FA37164E7E29D5D44176E6A5299AACC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8989FD0BDF65E50FBF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BB07C9E286C61B7F975ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A56DE33C4B801DEA318A027DFE25285BAA66A738EF9BAB4960D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75FA7FF33AA1A4D21C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340A4C04F5DECA7EE9A6EBA7E8973B4D74504698B123F78EE0C36488CF05DB91B2B8429F93C2C64E3B1D7E09C32AA3244C783C39B72FCD1628ED998A7BFD1388E4C3B3ADDA61883BB5FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMEANdStWW5/lrlX6K6UDOw== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB401569F4D33D7759214CAAC725E4425B13230E485A062C70BF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 05/10] test: refactor with _dofile X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the patch! LGTM, except the nitpick regarding the commit message. On 26.07.21, Максим Корякшин wrote: > > Thanks for the review, Igor! > Here is the diff, that fixes typos in luajit-test-init.lua: >   > ================================================= > diff --git a/test/luajit-test-init.lua b/test/luajit-test-init.lua > index feec17cf..acd3d60e 100644 > --- a/test/luajit-test-init.lua > +++ b/test/luajit-test-init.lua > @@ -2,8 +2,8 @@ >  -- `_loadfile()` exists and uses it for code loading from test >  -- files. If the variable is not defined then suite uses >  -- `loadfile()` as default. Same for the `_dofile()`. > --- Lua-Harness also uses the same implementation of `dofile()` > --- fot he same reason > +-- lua-Harness also uses the same implementation of `dofile()` > +-- for the same reason. >  -- XXX: Some tests in PUC Rio Lua 5.1 test suite clean `arg` >  -- variable, so evaluate this once and use later. > ================================================= >   > >Max, > > > >Thanks for the fixes! LGTM, except the three typos in > >luajit-test-init.lua. > > > >On 20.07.21, Maxim Kokryashkin wrote: > >> The patch[1] from lua-Harness suite is quite similar to commit Typo: s/from lua-Harness suite/from the lua-Harness suite/ > >> d11c5bbc08a118b11167c5d455d4024607dab662 ('test: adjust lua-Harness > >> tests that use dofile'), with the one difference (except the naming): > >> `make_specific_checks()` provides the particular behaviour to run the > >> tests for out-of-source build, however `_dofile()` allows user to > >> overload this function considering his purposes. If user leave > >> `_dofile()` untouched, it defaults to `dofile()` Lua standard library > >> function. > >> > >> It's worth to mention, that LuaJIT testing machinery has been using > >> such approach since commit 734cc0f1d508429c2c3c46bd1860398db0051060 > >> ('test: adapt PUC-Rio suite for out-of-source build') and `_dofile()` > >> behaviour for running tests when out of source build is used is > >> already defined in luajit-test-init.lua. > >> > >> [1]: https://framagit.org/fperrad/lua-Harness/-/commit/60da289 > >> > >> Part of tarantool/tarantool#5970 > >> Part of tarantool/tarantool#4473 > >> --- > >> test/lua-Harness-tests/101-boolean.t | 2 +- > >> test/lua-Harness-tests/102-function.t | 2 +- > >> test/lua-Harness-tests/103-nil.t | 2 +- > >> test/lua-Harness-tests/104-number.t | 2 +- > >> test/lua-Harness-tests/105-string.t | 2 +- > >> test/lua-Harness-tests/106-table.t | 2 +- > >> test/lua-Harness-tests/107-thread.t | 2 +- > >> test/lua-Harness-tests/108-userdata.t | 2 +- > >> test/lua-Harness-tests/203-lexico.t | 8 ++++---- > >> test/lua-Harness-tests/231-metatable.t | 2 +- > >> test/lua-Harness-tests/301-basic.t | 2 +- > >> test/lua-Harness-tests/305-utf8.t | 4 ++-- > >> test/lua-Harness-tests/404-ext.t | 2 +- > >> test/lua-Harness-tests/test_assertion.lua | 10 ++-------- > >> test/luajit-test-init.lua | 2 ++ > >> 15 files changed, 21 insertions(+), 25 deletions(-) > >> > > > > > > > >> diff --git a/test/luajit-test-init.lua b/test/luajit-test-init.lua > >> index 54a1f815..feec17cf 100644 > >> --- a/test/luajit-test-init.lua > >> +++ b/test/luajit-test-init.lua > >> @@ -2,6 +2,8 @@ > >> -- `_loadfile()` exists and uses it for code loading from test > >> -- files. If the variable is not defined then suite uses > >> -- `loadfile()` as default. Same for the `_dofile()`. > >> +-- Lua-Harness also uses the same implementation of `dofile()` > > > >Typo: s/Lua-Harness/lua-Harness/. > > > >> +-- fot he same reason > > > >Typo: s/fot/for/. > >Typo: Dot is missing at the end of the sentence. > > Side note: I suppose the same comment should be added in the Tarantool's init file. > >> > >> -- XXX: Some tests in PUC Rio Lua 5.1 test suite clean `arg` > >> -- variable, so evaluate this once and use later. > >> -- > >> 2.32.0 > >> > > > >-- > >Best regards, > >IM >   >   -- Best regards, Sergey Kaplun