From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D978F6EC55; Tue, 27 Jul 2021 12:28:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D978F6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627378117; bh=xBx2GPTSphn/O64xptN4x4RSNUgUJ9/MpUtMEpUPxmw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Qx5OPYsbQf7UPOD7KOw6okwZuK8h+WPB6BOesO3R6BcaxTvA830Jqf3zoZCmtwUb2 RukxUOgZZJIAc99d7ZBLpuUgl4K46nm3fsId07ZBN7CGcJyOEY47kVHQyBXLd82TMX fw+4jsmnns9B7pvUW//PK2wFiMdy6XjXR/jR3LBw= Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0800C6EC55 for ; Tue, 27 Jul 2021 12:28:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0800C6EC55 Received: by smtp36.i.mail.ru with esmtpa (envelope-from ) id 1m8JO6-0006po-8T; Tue, 27 Jul 2021 12:28:34 +0300 Date: Tue, 27 Jul 2021 12:27:22 +0300 To: Igor Munkin Message-ID: References: <20210725210928.GF27855@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210725210928.GF27855@tarantool.org> X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD941C43E597735A9C34755E0A9F196FCB739C645213AB7C8E0182A05F538085040699B416F0BABF7546FE7897451A5DB0C5F4DA88832ACD2A9959172F71E13842B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F9D3BE5B596754B8C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE79E25BE5045FD62C0EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F22556F7EB55A20230284E518B9342AC48CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8A9FF340AA05FB58CF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BB07C9E286C61B7F975ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5A7A7A94EF86061814DDC7CF01701123F667E313ED619CBC0D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75FA7FF33AA1A4D21C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34524B2D44961BF9C69A916528D1FBCCB8C31E08C09BC822C71E8671E3425B00E734AAD10A754204681D7E09C32AA3244C6F19BB86B987DAA946BADAC85C1EAAD3F165894D92D62706FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMEANdStWW58lDtYGwhSxsw== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4282A74DA76D98020ACC92B9A225BC81165AA5CEE0DD0B02FF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 04/10] test: refactor with _retrieve_progname X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Max! Thanks for the patch! LGTM, except several nitpicks regarding the commit message: =================================================================== test: refactor with _retrieve_progname The patch[1] from lua-Harness suite fixes the same issue commit Typo: /from lua-Harness suite/from the lua-Harness suite/ Typo: /commit/as the commit/ 837688590919fcf8de47ef90479fd2a640c8fddc ('test: adjust lua-Harness suite to CMake machinery') does except the single difference: `get_lua_binary_name()` is called `_retrieved_progname()`. As a result of this patch the function is renamed to follow the original naming. [1]: https://framagit.org/fperrad/lua-Harness/-/commit/1be25a8 Part of tarantool/tarantool#5970 Part of tarantool/tarantool#4473 =================================================================== On 26.07.21, Igor Munkin wrote: > Max, > > Thanks for the fixes! LGTM. > > -- > Best regards, > IM > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- Best regards, Sergey Kaplun