From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id AC5B96EC55; Tue, 27 Jul 2021 12:03:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AC5B96EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627376595; bh=IAgJbnGiHv51/4i6nMmtNJcISH9MgEpSWAcbA2dxugw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=YzvDWvCzYskkjF1fyNxAh/z7eMH6ViAAiNQ9FwlEKlv5jvyR7KrpI1bQ0avQMgEB+ +0qRjAhaOlm0V0+jQBvhdnDAH8lA8Eg9PotPMRM4PR6Y+cCmk79QeiW1oIKpmwkBd6 uoqi0ZGrMPitk3TzsPeudFqYmQOTzPNLc9wuBX5U= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3C5726EC55 for ; Tue, 27 Jul 2021 12:03:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3C5726EC55 Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1m8IzX-0007Fi-84; Tue, 27 Jul 2021 12:03:11 +0300 Date: Tue, 27 Jul 2021 12:01:59 +0300 To: Igor Munkin Message-ID: References: <20210725210906.GE27855@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210725210906.GE27855@tarantool.org> X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C30288BCF456A452EC429C5145D5B58EFD182A05F538085040C6D3B43BC29E0567FA7188E51099573B79DC240B8F0914A87EC8101F56141DA2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7544B1CCE26E01C74EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CDA089757FB31C668638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C9DC7B4CDFA21AC8D34F87660FDD6222117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B65D56369A3576CBA5089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5063688743730C928504A66D05E82C630B4BC94F763535851D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7536C62C4FBC402878410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34315359784EE451039126C6A992ED901DC62F71259E2CD914F22A2EFDF5FFCD8D56008B35C7108FB81D7E09C32AA3244CFF381A4B1C1A0B29FD97AE3B9C729D647101BF96129E4011FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMEANdStWW58Hdn+96HTZDA== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB463BCA9ABA08B06A939E624DD9AED30C6091DED475A21ADD3F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 03/10] test: use CI friendly variables in lua-Harness X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the patch! LGTM except a few nits regarding to the commit message. =================================================================== test: use CI friendly variables in lua-Harness In scope of the commit 45ed138dcb9228d8ac5b8d82331ddd20a0bfada1 Typo: s/In scope/In the scope/ ('test: set USERNAME env var for lua-Harness suite') the environment of the testing process is tweaked via CMake, since both LOGNAME and USERNAME environment variables might be missing. Actually, POSIX standard states that every user must have HOME environment variable set. It allows to use this in the corresponding Typo? s/this/this variable/ assertion instead of LOGNAME and USERNAME without additional environment setup. As a result this patch[1] from lua-Harness suite supersedes the mentioned commit, and CMake hack can be dropped. Typo: s/CMake hack/the CMake hack/ [1]: https://framagit.org/fperrad/lua-Harness/-/commit/6c2aa87 Part of tarantool/tarantool#5970 Part of tarantool/tarantool#4473 =================================================================== On 26.07.21, Igor Munkin wrote: > Max, > > Thanks for the fixes! LGTM. > > -- > Best regards, > IM -- Best regards, Sergey Kaplun