From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 017E56EC55; Mon, 12 Jul 2021 11:12:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 017E56EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1626077537; bh=9GPhhHtUcyX2AHQVhK6sll2ztS8fF1f9SlZXkDd9qac=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=yXf5Fh2vEt7JTcKqDVqguo8XU1tv4Mdg0EQ8EK2vw3KZPvDDyaxCEti8mq87oXVnv ZySQRvjVaXV4+5iiB5cL+Z8bnfvWwZyTm/ER1quNs67uoqdiHO+QJOabFczrtIigsX xaIo0I/MhzwBgpYzWUvyJbgpKUEzn9J9hB+qPsDA= Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8697D6EC55 for ; Mon, 12 Jul 2021 11:12:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8697D6EC55 Received: by mail-lj1-f178.google.com with SMTP id h9so7474573ljm.5 for ; Mon, 12 Jul 2021 01:12:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7AvsMUS+h8BiGV92H9NZHgcqtt/ARUUy/e+BJa63hUE=; b=d5+1IzvDXBfe55Z5LVH+OxukgLiRCAWYOEMIllZZ3aylxkr3addihTRVaIU38ufWkM DaLQjbh+YzGwPeLsuRfz0/3b2ICxyP58OjvF29s7d8Bo81rWcefmtRSRL1EzgFyxhzHD yahn7RH8TeAsP2r5BEezUaSEa3/Cvstdaq9ZA6vJZWFP0xuexY1HzTL8zfTnEG5D6nnt G7jtxOj0MYVTLMgteB1DgkYxDfrB0ywLEVqmZb3i/6AHQOCHth4WZafpTnqUUN51ttvc v1NFMJcw7OWhGnG9C0o8R2eMN1556fn+05bktQcuOPxIbRKRSGHxarD6HQdu5n6vBdTE gezg== X-Gm-Message-State: AOAM532XFIFymcv5pShn8J3kAOpDpJYELVel7yiRyq0ZLFAZ4iVztW3N /D++OQ3pA+QV5EOldf2U+I6ET1QjOXhQow== X-Google-Smtp-Source: ABdhPJy9TEijAC5apiMy9NAtQAkfSJ+hDJOaKW25NueqfM3GTPaaNguocfpA/41H2uhYgpHTjTb6FA== X-Received: by 2002:a2e:9d15:: with SMTP id t21mr40870429lji.200.1626077534633; Mon, 12 Jul 2021 01:12:14 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id b10sm1436485ljj.109.2021.07.12.01.12.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 01:12:13 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id D67635A001E; Mon, 12 Jul 2021 11:12:12 +0300 (MSK) Date: Mon, 12 Jul 2021 11:12:12 +0300 To: Vladislav Shpilevoy Message-ID: References: <20210710222803.253251-1-gorcunov@gmail.com> <187d1ae2-99cb-50d4-d5b4-18aa6c5f5546@tarantool.org> <36639f07-5c56-5c94-d563-0862135d0ea9@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <36639f07-5c56-5c94-d563-0862135d0ea9@tarantool.org> User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH] limbo: introduce request processing hooks X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Mon, Jul 12, 2021 at 10:04:56AM +0200, Vladislav Shpilevoy wrote: > > > > And if we filter before the WAL write, we need the second vclock, which > > Cyrill has introduced. > > Why do you need a second vclock? Why can't you just filter by the > existing vclock and update it after WAL write like now? Because the phases are no longer atomic. We can pass "filter" stage, update our terms, but then WAL process failed (it doesn't matter for what reason, maybe single disk write failure) so we have to revert former term value back so the client will retry the operation and resend us the PROMOTE.