From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 678C76EC55; Fri, 9 Jul 2021 13:10:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 678C76EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625825444; bh=Y+QFE0OLGkXXV83SNeI4v1RZcv+jJUoa8ddW7EFe6pg=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=hPVQEWw1IpcOKaVIOez8IUFL8E+3T0bP/V4DRRxH4hTPPxMCSLes7SXt7kUmfpewJ K9ErAEtFVookgOTIUEuhVEJsTDXbGIdgpPENuGF4OOb5UmKBv7Bh+iEwbBfiMjoyJl RgtgFBtWE8NYlV+e5cRyz6LdVKS3M7/oVKG9yemw= Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D8F526EC55 for ; Fri, 9 Jul 2021 13:10:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D8F526EC55 Received: by mail-lj1-f180.google.com with SMTP id u25so7197425ljj.11 for ; Fri, 09 Jul 2021 03:10:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7LfFFZmHYWXzdWDIpnNj6YjQ0bpx6Y3Cy7AuqnqvWEo=; b=g5YkYv9Xqhw6bDad0Bu6DhvaLFKckZprhsPrft5J37R02tn90wiYNLhoShoYflV/AN xWGO1hlSvWiby2ueifymr2EuMJTCNHF5D+2HShRvahUbxtV0PIkXwJBcZ58V8GOyxkBo sND1eNvCrGtWzxXLcNvcOnEHpvruf1IJAkp2x23wALafmRhgVYZmOgphKUYSLJWHpbMr DjQ6VqUldARDgoKlZ2G+rH3UXb0q7dXeHN6wPzQD5OW7/nPy2vfoa/yUbFX0A2IP49C6 uFhX44z+fmC0fTFev9O8uY1GDREMkanlpLGJMYQfTwP1x8dmg/IsBkAiUoCMluhlFB23 zqVQ== X-Gm-Message-State: AOAM5303hgik5rtZqOI1n4Sgtca0MNY0kCGUWDjBUlBEKMifbN2UrjKu G7ShzmxIVb5dp7wUm0jlPYWNOklJFL9szg== X-Google-Smtp-Source: ABdhPJxkclaYdCZGxUYC4rvLiAuasyVCRvMfSNF+KyFzcxeVlXRE4laKSsI75w6p9pHXGgEDbDVpjQ== X-Received: by 2002:a2e:858c:: with SMTP id b12mr24784377lji.449.1625825441711; Fri, 09 Jul 2021 03:10:41 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id r15sm427140lfr.245.2021.07.09.03.10.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jul 2021 03:10:40 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id C3B4D5A001E; Fri, 9 Jul 2021 13:10:39 +0300 (MSK) Date: Fri, 9 Jul 2021 13:10:39 +0300 To: Egor Elchinov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <202247f05706af029e37cff627542cc4d6dda4f7.1625170992.git.elchinov.es@gmail.com> <39ad0898-6d05-227c-adda-dcb50e6ec573@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39ad0898-6d05-227c-adda-dcb50e6ec573@tarantool.org> User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH 5/7] fiber: add dynamic option for parent backtrace X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Fri, Jul 09, 2021 at 12:50:40PM +0300, Egor Elchinov wrote: > > > -#ifdef ENABLE_BACKTRACE > > > +#if ENABLE_BACKTRACE > > > > Please don't squash unrelated changes into the patch. If you prefer > > to shange #ifdef to #if better make it as a separate commit (though > > I don't understand yet what is wrong with existing code) > Changes rebased into refactoring commit. > > I believe this is more conventional way to check the ENABLE_BACKTRACE option > because it is defined as > #cmakedefine ENABLE_BACKTRACE 1 > but not > #cmakedefine ENABLE_BACKTRACE For this particular case we don't check the _value_ of defined variable, we rather interested if it is defined at all. In general for conditional compilation we use #ifdef you know, and all our current code uses #ifdef ENABLE_BACKTRACE so I personally don't see much point in renaming statement. Still, up to you, but if you prefer #if form could you please make it as a separate patch. Cyrill