From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 70ACE6EC55; Fri, 9 Jul 2021 10:59:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 70ACE6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625817583; bh=0u0ySavd2bQ1aMbG20Ua9JH6fWQ8bLa/S6eunW+QxEs=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=o+s4nIIpdBk9Ve2haRMFaIKoVSEcGTRV3/35ybqB2DY0Y+m8hzQw3gFOAHnbSpnRy a1mdCOsJq+AoJNaAt1ePYRyaHLyCQN6mjxIG2M/ClEI0KHKao6ZfCReF9fkB/3jsIP g46ppiHAHx4Xx+pC5RbskPYN8trzCr07V+xJ023s= Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 04BDF6EC55 for ; Fri, 9 Jul 2021 10:59:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 04BDF6EC55 Received: by mail-lf1-f41.google.com with SMTP id x25so8842060lfu.13 for ; Fri, 09 Jul 2021 00:59:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9zPXb2T4PwvIx3Tg5RYe3NffISQJoY7ObKxm7XwXB68=; b=UhFAJyDpyQUV76My5FMDh0M7AergVQV2vFBu+fSig3oqzjWshNirXCLdSuBg58U7Om 0gtvkynXspDedtrMptVvkHWk1u+0ZI4R2cS8QDf+9J51Y8NrrKrjMtojq1XgkfShAXZk 6GxBsmb0d/DKtgoy4EKn66BLsQ6VIgwm7ixdWOiiOo6teWJjirXKL9/UwptO0K7Vz+b9 dEVsocRrIUAf4FS7VeUc4qxHI4dKPZEj3/6fvRRV2f/xV2Iml6LIL4w5sSETYw7C8Yy0 sKH5VhOV4WvBGM6ramladpK9Xep+/+nMd8cV/oBu3pjhi/4gam90av3FL306orEzEAu1 ZGTA== X-Gm-Message-State: AOAM5308A3Mwe3kc8a+5q80hkLx696gj2SIoRrWeotks5/btYcD0Cb6H eGlmvVXdarUIjzZUEx641naWIzqANyz7EA== X-Google-Smtp-Source: ABdhPJyXHO6kQEQXAJGVAkdTrXLO5SsVDuAn0iifDvZeGcINovCzpheSLNtrSYIOqB61KrMsI3Sv9w== X-Received: by 2002:a05:6512:2618:: with SMTP id bt24mr17490248lfb.180.1625817580992; Fri, 09 Jul 2021 00:59:40 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id r15sm487821ljh.96.2021.07.09.00.59.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jul 2021 00:59:40 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 7DAD75A001E; Fri, 9 Jul 2021 10:59:39 +0300 (MSK) Date: Fri, 9 Jul 2021 10:59:39 +0300 To: Serge Petrenko Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org Message-ID: References: <20210709074048.18169-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210709074048.18169-1-sergepetrenko@tarantool.org> User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH] replication: stop pushing TimedOut error to the replica X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Fri, Jul 09, 2021 at 10:40:48AM +0300, Serge Petrenko wrote: > @@ -549,6 +550,12 @@ iproto_write_error(int fd, const struct error *e, uint32_t schema_version, > > size_t region_svp = region_used(region); > mpstream_iproto_encode_error(&stream, e); > + struct errinj *inj = errinj(ERRINJ_IPROTO_WRITE_ERROR_LARGE, > + ERRINJ_INT); > + if (inj != NULL && inj->iparam > 0) { > + char garbage[inj->iparam]; Serge, I didn't read the patch yet but this moment is very dubious. While standart allows to allocate dynamic stack here it may lead to unpredicted effects. I would suggest to use malloc if this won't cause significant rework, hm? Surely this can be done on top of the patch (actually you did a huge amount of great work investigating this issue, thanks!!!)