From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 868256EC40; Thu, 8 Jul 2021 01:05:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 868256EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625695508; bh=nPcGCqu5MndBEr4q5FUNskRtHSfb6AyFtrnlitzJfjI=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=M8t+2UIW2zAxvIWb/atbr0rEaJKl8wSlN4iJdrk1pOcZsHfYKoVcdTiiL1/YFYws7 777anQLW5k3ggn9AOPab3YV31QDXl7VnTxI59i266tPjO6gL1IxtHGKFg5Iw7CGXIc 4OZvJnjSl+o6FVZ+kc8lkywET9acYEnUH1ogaIBk= Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 001646EC40 for ; Thu, 8 Jul 2021 01:05:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 001646EC40 Received: by mail-lf1-f52.google.com with SMTP id p21so8244965lfj.13 for ; Wed, 07 Jul 2021 15:05:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TOfXU8lqOWBeWvQjvUSt/jbCSXUUyivEYqP4ykmlrqo=; b=Scil67LELK71+2m/znEYNq2CB3NptvO7XpnLOiKsWAKdZoNODSult6qtaPtxMFq12N sGXJPr2TKpiVtCU1Q3q5v/0jAYzYZONnTwLOxGXma+Dd556i7ZF0A6+TKQPwZuHvsqCz S0PDpvX+3vQRJqRAjTne+VqG1uiR9eY3KKAkLtN0wpGspQ3mbva8BCFr+uapYUsWJJe9 +bTrX+xwEQIHoTE3n904sG4I5bMhAMXLwE5EfJlaJ2BSQDT7UY54nkbnpJfZIE/gSYee WPLl8E1S/BD4QOrj5T3EXZgn9z8aBZO6RWzk9WI7JNVyJh1PYLnqSynPHw0nsqHuuUOx /A/A== X-Gm-Message-State: AOAM531RIl5g8psWsTFsz1EO1M6yOJlhhvlRbeRTMhkIdA5hVwrXq9oe l2Oha+JKzFIAAD2p6fAtadCWvpn+E94= X-Google-Smtp-Source: ABdhPJy/5u7yT5VkhQtc/z+THM/VDdFcvh0WwO4zBqhEMKVgh93HD+2B+dlC+LIErgL64x80LJ+YYg== X-Received: by 2002:ac2:5d22:: with SMTP id i2mr20644683lfb.371.1625695501880; Wed, 07 Jul 2021 15:05:01 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id m20sm13997lfu.8.2021.07.07.15.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jul 2021 15:05:00 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 24BE45A001E; Thu, 8 Jul 2021 01:05:00 +0300 (MSK) Date: Thu, 8 Jul 2021 01:05:00 +0300 To: Vladislav Shpilevoy Cc: tml Message-ID: References: <20210625100707.87807-1-gorcunov@gmail.com> <9652278e-570e-40e5-b2d1-856fe58179fc@tarantool.org> <4b0f4d8f-4e0c-00d0-38ad-0b6abad3aafe@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH] raft: more precise verification of incoming request state X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, Jul 08, 2021 at 12:59:33AM +0300, Cyrill Gorcunov wrote: > > 2. You deleted the state decode. I assume not a single replication > > test passes now, correct? > > Nope :) I write it back a bit later once verification is complete. > I ran the test locally before sending the patch. Vlad, I think I know what happened: there was a typo which I fixed and commited locally but didn't force pushed out. Just realized it. I updated repo. But since we gonna switch to uintX instead of enum I think it doesn't worth to resend the patch.