From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 806B06EC40; Mon, 5 Jul 2021 10:51:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 806B06EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625471500; bh=g79iJNaUonnFOwEGBhxJJ+cs1qs0VdknxR6h7Z0lhfs=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=oJHkZlUbYzf5xPSe9Q/nQqT66OvGnbF/LHLtNg2vj46M2Y9gNvOGq9Zuy2Pscztq4 kyYv0Ay4SwY3NieoqnB1Gw9HsCwq416w3v/MWDXmeKbfUQxPhbw340n1odb/Ezruka aQd5+bsxIZRigKSgmLZZT7v+9IJTUWCT0jCdLiS8= Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 19AF66EC40 for ; Mon, 5 Jul 2021 10:51:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 19AF66EC40 Received: by smtp60.i.mail.ru with esmtpa (envelope-from ) id 1m0JOF-0003vU-Cg; Mon, 05 Jul 2021 10:51:39 +0300 Date: Mon, 5 Jul 2021 10:50:33 +0300 To: Mikhail Shishatskiy , tarantool-patches@dev.tarantool.org Message-ID: References: <20210630142020.326411-1-m.shishatskiy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB0C620705B15DE32DFE392EA95FA71EAB182A05F538085040326815AA6DB2685BC5C2CE399CEBD58F99B7E307780F6D711EA75A7B8853CE6A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A2F2DCC785917A3AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E0B09B181166DBFC8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D870FA1B93B7C62ACB4CA920025188B4A8117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAA867293B0326636D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A1DCCEB63E2F10FB089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5B4BDF2529A58803D731BA1A070DACA2902A301CDA3076D08D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7569E77FCA7B33833F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34E420FF71F2F0FE03C644E30F6302A3EEFE366F9C95FE19C01D27CBFD1E9DC4DB21C3EEFC67883B771D7E09C32AA3244C86EC892041A039817D15796E549A6F897C0C08F7987826B9729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj5fH2RN9TpJmgZVqTsypMiQ== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4E07FF52FD03EF6504CC31582C64F704112EB7169440E0F68F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] luajit-gdb: fix misalignment in lj-stack X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, again! Sorry, one more nit to the commit message. On 05.07.21, Sergey Kaplun via Tarantool-patches wrote: > Hi! > > Thanks for the patch! > LGTM, except several nits to the commit message. > > On 30.06.21, Mikhail Shishatskiy wrote: > > | luajit-gdb: fix misalignment in lj-stack > > Please use just > | gdb: fix misalignment in lj-stack for LJ_GC64 > "tag" (you can check all tags types in the git log). > > > When LJ_GC64 was enabled, the alignment of stack slots printed by > > lj-stack command failed. It looked like the following: > > Nit: I suggest reformulate it like the following: > > | When LJ_GC64 is enabled, stack slots printed by lj-stack command > | are misaligned. > > > > > | 0x7ffff7fb0d90:0x7ffff7fb0dc0 [ ] 7 slots: Red zone > > | 0x7ffff7fb0d88 [ M] > > | 0x7ffff7fb0cc0:0x7ffff7fb0d80 [ ] 25 slots: Free stack slots > > | 0x7ffff7fb0cb8 [ T ] > > Nit: please describe the reason of this issue > > > > > This patch fixes the output to look as expected: > > Nit: by how? > > > > > | 0x7ffff7fb0d90:0x7ffff7fb0dc0 [ ] 7 slots: Red zone > > | 0x7ffff7fb0d88 [ M] > > | 0x7ffff7fb0cc0:0x7ffff7fb0d80 [ ] 25 slots: Free stack slots > > | 0x7ffff7fb0cb8 [ T ] > > > > To test changes do the following: > > > > | $ gdb -q --args ./luajit -e 'print("QQ")' > > | Reading symbols from ./luajit... > > | lj-arch command initialized > > | lj-tv command initialized > > | lj-str command initialized > > | lj-tab command initialized > > | lj-stack command initialized > > | lj-state command initialized > > | lj-gc command initialized > > | luajit-gdb.py is successfully loaded > > | (gdb) lj-arch > > | LJ_64: True, LJ_GC64: True > > | (gdb) b lj_cf_print > > | Breakpoint 1 at 0x298b0: file /mnt/WorkDisk/share/dev/__tarantool/lj-tarantool/src/lib_base.c, line 485. > > | (gdb) r > > | Starting program: /mnt/WorkDisk/share/dev/__tarantool/lj-tarantool/src/luajit -e print\(\"QQ\"\) > > | > > | Breakpoint 1, lj_cf_print (L=0x0) > > | at /mnt/WorkDisk/share/dev/__tarantool/lj-tarantool/src/lib_base.c:485 > > | 485 { > > | (gdb) s > > | 486 ptrdiff_t i, nargs = L->top - L->base; > > | (gdb) lj-stack L > > | 0x7ffff7fa8d90:0x7ffff7fa8dc0 [ ] 7 slots: Red zone > > | 0x7ffff7fa8d88 [ M] > > | 0x7ffff7fa8cc0:0x7ffff7fa8d80 [ ] 25 slots: Free stack slots > > | 0x7ffff7fa8cb8 [ T ] > > | 0x7ffff7fa8cb0 [ B ] VALUE: string "QQ" @ 0x7ffff7fb1178 > > | 0x7ffff7fa8ca0:0x7ffff7fa8ca8 [ ] FRAME: [L] delta=2, fast function #29 > > | 0x7ffff7fa8c90:0x7ffff7fa8c98 [ ] FRAME: [V] delta=2, Lua function @ 0x7ffff7fb1240, 0 upvalues, "=(command line)":0 > > | 0x7ffff7fa8c80:0x7ffff7fa8c88 [ ] FRAME: [CP] delta=4, Lua function @ 0x7ffff7fb1240, 0 upvalues, "=(command line)":0 > > | 0x7ffff7fa8c78 [ ] VALUE: C function @ 0x55555555c962 > > | 0x7ffff7fa8c70 [ ] VALUE: light userdata @ 0x0 > > | 0x7ffff7fa8c60:0x7ffff7fa8c68 [ ] FRAME: [CP] delta=2, C function @ 0x55555555df1c > > | 0x7ffff7fa8c58:0x7ffff7fa8c60 [S ] FRAME: dummy L > > Thanks for the test case! Please delete it from commit message (it's > redundant there, I suppose). You can mention it in the mail itself after > "---" before the diff entry [*] (see below). > > > > > Fixes: tarantool/tarantool#5876 Nit: Don't use ":" in the ticket-mentioning, just: | Fixes tarantool/tarantool#5876 > > > > Branch: https://github.com/tarantool/luajit/tree/shishqa/gh-5876 > > This too [*] (especially it is not a part of the commit message). > > > > > --- > > <<< [*] Exactly here. > > > src/luajit-gdb.py | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py > > index f1fd6230..720d989a 100644 > > --- a/src/luajit-gdb.py > > +++ b/src/luajit-gdb.py > > > > > -- > > 2.32.0 > > > > -- > Best regards, > Sergey Kaplun -- Best regards, Sergey Kaplun