From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9DF7A6EC40; Mon, 5 Jul 2021 10:49:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9DF7A6EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625471387; bh=VmvhayC+qmHk9du4tl7q/ufyzhxvzsBwfH6WxuwF3+A=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=j0eTF4XRXPRhfRdPJFgYl2JvX5a11RoD3N0EEUsop3DnhbuXqFefvBkv7+y9JzlyK y7Cww1c7bXJr6V9bQiL7Wsa5g2cOXZ60Lh1IPKu5tm+sVW0zcpTJv2OREDLADhBVs/ ZJgJ5EBaGYftF2a2+GymI407xPbEjYTwn9WbbkP0= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6EA456EC40 for ; Mon, 5 Jul 2021 10:49:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6EA456EC40 Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1m0JMP-0003Q8-Q5; Mon, 05 Jul 2021 10:49:46 +0300 Date: Mon, 5 Jul 2021 10:48:39 +0300 To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <20210702133139.91528-1-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210702133139.91528-1-max.kokryashkin@gmail.com> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB96E19CC2B9345E2B1F8975EC27617E56182A05F538085040EAAFA7021E61BC56095C5D4268F6FAF14B6F8C67B7A96600BA82B6D9B1CBD759 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C2204D4F9A221771EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374CC1EE7F84E0F1BE8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D83A2172CEC431B58D128834D488D0218E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCECADA55FE5B58BB7A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10F6FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A589A0F3ACA702A889D5C0240295FA4CC7561A30247182C3CFD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7569E77FCA7B33833F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3483E1FCD56FEA62E6C52030B969B7FF0B764068113260C3CBC39A34C5938418924ADB5CB86E4D84B91D7E09C32AA3244CBFE54FC18597E4659D5191CF13CEE3D705AB220A9D022EBC729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj5fH2RN9TpJkdckYpuSWIEA== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4BBE6A1B932624317D5E434E409C2B8E53F7167517F9BCC2EF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] test: bump lua-Harness suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! Side note: please add to "To:" field somebody (usually two persons) you want to review your changes. Please separate patchset to the commits of the upstream (with mentioning cherry-picked commit with full hash to avoid hash clashing -- you can see examples in the git log). It is easier to review unrelated changes one by one. On 02.07.21, Maxim Kokryashkin via Tarantool-patches wrote: > As our experience has been considered by the maintainer of lua-Harness and the issues we faced are finally fixed in mainline repo, we should bump lua-Harness suite up to 7040458. We have 72-symbol line width in the commit message body [1], please reformat it. > > Changes: > - The patch `fperrad/lua-Harness@1be25a8` from lua-Harness suite is the same as the patch `tarantool/luajit@8376885` from `tarantool/luajit`, except for `get_lua_binary_name()`, which was renamed to `_retrieve_progname()` in `fperadd/lua-Harness`. > > - The patch `fperrad/lua-Harness@24a570c` from lua-Harness suite is completely the same as the patch `tarantool/luajit@789820a` from `tarantool/luajit`, so no changes are required. > > - The patch `fperrad/lua-Harness@60da289` is similar to the patch `tarantool/luajit@d11c5bb`, but `make_specific_checks()` was renamed to `_dofile()` by maintainer. Another difference is that it seems like there is no definition for `_dofile()` in mainline lua-Harness, so it should be user-defined somewhere. If it is not, then `_dofile()` will act like `dofile()`. Considering this, we should keep `make_specific_checks` implementation from `tarantool/luajit@d11c5bb`, but rename it to `_dofile` and move to `tap.lua`. > > - The patch `fperrad/lua-Harness@6c2aa87` makes 309-os.t check `os.getenv()` function by examining HOME environment variable instead of USER, so we don't need to set USERNAME explicitly anymore, as it stated in POSIX standard that every user must have HOME varibale set. Therefore, `tarantool/luajit@45ed138` should be replaced with `fperrad/lua-Harness@6c2aa87`. > > - The patch `fperrad/lua-Harness@8041c45` renames `tap` module to `test_assertion` to avoid name collisions, hence, we can just apply this patch. > > Github branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-5970 Please provide all patch description between "---" and diff files mentions [*] (see below), to avoid confusion -- it is not a part of the commit message. > > Closes : #5970 Please use | Part of tarantool/tarantool#5970 for the first patches and | Resolves tarantool/tarantool#5970 for the last patch instead (it will be closed after bump LuaJIT version in the Tarantool). > --- <<< [*] Exactly here. > test/lua-Harness-tests/090-tap.t | 2 +- > test/lua-Harness-tests/091-profile.t | 2 +- > test/lua-Harness-tests/101-boolean.t | 4 ++-- > test/lua-Harness-tests/102-function.t | 4 ++-- > test/lua-Harness-tests/103-nil.t | 4 ++-- > test/lua-Harness-tests/104-number.t | 4 ++-- > test/lua-Harness-tests/105-string.t | 4 ++-- > test/lua-Harness-tests/106-table.t | 4 ++-- > test/lua-Harness-tests/107-thread.t | 4 ++-- > test/lua-Harness-tests/108-userdata.t | 4 ++-- > test/lua-Harness-tests/200-examples.t | 2 +- > test/lua-Harness-tests/201-assign.t | 2 +- > test/lua-Harness-tests/202-expr.t | 2 +- > test/lua-Harness-tests/203-lexico.t | 10 +++++----- > test/lua-Harness-tests/204-grammar.t | 2 +- > test/lua-Harness-tests/211-scope.t | 2 +- > test/lua-Harness-tests/212-function.t | 2 +- > test/lua-Harness-tests/213-closure.t | 2 +- > test/lua-Harness-tests/214-coroutine.t | 2 +- > test/lua-Harness-tests/221-table.t | 2 +- > test/lua-Harness-tests/222-constructor.t | 2 +- > test/lua-Harness-tests/223-iterator.t | 2 +- > test/lua-Harness-tests/231-metatable.t | 4 ++-- > test/lua-Harness-tests/232-object.t | 2 +- > test/lua-Harness-tests/241-standalone.t.disabled | 4 ++-- > test/lua-Harness-tests/242-luac.t | 4 ++-- > test/lua-Harness-tests/301-basic.t | 6 +++--- > test/lua-Harness-tests/303-package.t | 6 +++--- > test/lua-Harness-tests/304-string.t | 2 +- > test/lua-Harness-tests/305-utf8.t | 4 ++-- > test/lua-Harness-tests/306-table.t | 2 +- > test/lua-Harness-tests/307-math.t | 2 +- > test/lua-Harness-tests/308-io.t | 4 ++-- > test/lua-Harness-tests/309-os.t | 8 ++++---- > test/lua-Harness-tests/310-debug.t | 2 +- > test/lua-Harness-tests/311-bit32.t | 2 +- > test/lua-Harness-tests/314-regex.t | 2 +- > test/lua-Harness-tests/320-stdin.t | 4 ++-- > test/lua-Harness-tests/401-bitop.t | 2 +- > test/lua-Harness-tests/402-ffi.t | 2 +- > test/lua-Harness-tests/403-jit.t | 2 +- > test/lua-Harness-tests/404-ext.t | 4 ++-- > test/lua-Harness-tests/411-luajit.t.disabled | 4 ++-- > test/lua-Harness-tests/CMakeLists.txt | 5 ----- > .../{tap.lua => test_assertion.lua} | 12 ++++++++++++ > 45 files changed, 82 insertions(+), 75 deletions(-) > rename test/lua-Harness-tests/{tap.lua => test_assertion.lua} (95%) > [1]: https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message -- Best regards, Sergey Kaplun