From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B5ED06EC40; Mon, 28 Jun 2021 09:31:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B5ED06EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1624861876; bh=caRwftqtbC+2pyT4tORVojWCVNPh1BMlpGT+pz1egk0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Ry5H6wmc9KiJAXa9bg43jJ5fYNOsJyldrK14KPVHYlohwfS9n0+mVGV76GRqnCAVN 070KCtgWDgT2Jj//sQXD6XxVMeOgLjOy2zOW71qMvBS+zQPm1uyLmIQU1WJs28Yufa 6mYnVN9u3WyHpWjjrjGaD6gJf2BEw9nSnfO11pY4= Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 358746EC40 for ; Mon, 28 Jun 2021 09:31:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 358746EC40 Received: by mail-lf1-f46.google.com with SMTP id d16so30519560lfn.3 for ; Sun, 27 Jun 2021 23:31:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4T95Wxryewt6o4TQRwCtw5UwoTsVR+k6h8bKMcs28JA=; b=GvVf76w0S2KRU/GTi/VLPdxRYWTMYW0smji/CzHXvuMwdVRSpB8W9xu4eOvMjwAHWg nxBk/NdXzOT69eONS8DFGXt8iOJ03MzKdAXUwUbelFFHW6Z4KCSPYRJrLjPYGHcRCKxw 3A1bmRPL8un/OfjlkfLyV3q1kEUSyGRsoqTZXcB6WMMWHFrqvRMJfiz5ADoEud7j6e3f 0YAzMnnRN4lYVJvnWWdLE1UFoZt1uNrLklBm/GBl7nuPjPMJS6PTF6RjcjKUPVP6iv4Q lXdjsCel8wVshyp16/um19UeLZ8A3E9T9sswJ0Z26j+CRv1jt0BCfu28hJ+w9hglL/kb 3TXw== X-Gm-Message-State: AOAM532Lx4KINQGKxzS1zuMgl7oRkzI2ucceD1Rt5o+uKJeJ2idLGoSf uQ4z0rftqnLeQgyQEGiEeIvFZQy9+xc= X-Google-Smtp-Source: ABdhPJzTL7hd8qeyq4GcH8uMpm/fSIIqOW3jElnQicRnYBP/Ge59CghmoRQfnzHPD8PjX5tMNuAFBQ== X-Received: by 2002:a19:771a:: with SMTP id s26mr17948225lfc.372.1624861874044; Sun, 27 Jun 2021 23:31:14 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id l15sm1461726ljc.35.2021.06.27.23.31.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Jun 2021 23:31:12 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id D96445A001F; Mon, 28 Jun 2021 09:31:11 +0300 (MSK) Date: Mon, 28 Jun 2021 09:31:11 +0300 To: Alexander Turenko via Tarantool-patches Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH 0/4] RFC: Isolate serializer helpers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: Cyrill Gorcunov , Vladislav Shpilevoy , Alexander Turenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Wed, Jun 23, 2021 at 10:12:38PM +0300, Alexander Turenko via Tarantool-patches wrote: > Moved the serializer helpers into its own compilation unit, add some > comments and a basic test: everything is just to simplify diving into > this code. > > Guys, please, look, whether it seems useful enough to include into > tarantool's mainline? Should we name it serializer.[ch] or > somehow like serializer_helpers.[ch]? > > Part of https://github.com/tarantool/tarantool/issues/3228 > Branch: Totktonada/gh-3228-extract-serializer-helpers The series looks ok to me, I think we should give it a spin.