From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1932D6EC58; Thu, 24 Jun 2021 09:17:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1932D6EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1624515468; bh=odHJU8qlBs2Co+DQquS20irBUSs88lX8CJhzMrb0vkY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=sg44Qqdi2VjjczujiQSlDbHLlGX5aWY0qS4y6H1+FM/TFUevaefgexZCbGCPeMajP i5KKhvY2czWFmsThRxBC2vhiDkyJ8Pq4/HAmihHDISnu2YZnP+PWQiBN7g3ScysILb WPGsNQbZrY440JeqnRuQlZoqrFlcngcBrrYTE3Xg= Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4E83C6EC58 for ; Thu, 24 Jun 2021 09:17:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4E83C6EC58 Received: by mail-lf1-f49.google.com with SMTP id a15so516492lfr.6 for ; Wed, 23 Jun 2021 23:17:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=phY2+LayV3dCglLW6EnIV6jU/4DyWu/bPAeo3NHGdrQ=; b=PFFp8nscEeLlpvc29nKCtivdqJEtI2vQbFD4UiGAaOq5JCfYTfnMuqwgNj4BSaG3tP oP8kSAdUXEwVo38N+GauNcFnSz+3QCGhU8T1QLKKGs70NOaDOpffdkAiN9ufI5L/D0WB yBOmmdPlzEe9UbrgJFOLVv2SjSe1qjA+jmzoZQ1MrFAaFtN6gDRF9L3qxuek1YqU9tBK 2P3ZfBL1GwzmH9TBw7IoTXsPQYewp2Gz6nB/e/7YJjsxsOauMFwlPKOi+AR5hJ13pg+n 2O2DORqyvBbXbA4f+HpGeSd1KbH/5s9Bw61d+7rG5jwjGjbrQzH5T6J4RAwfgO4Ba66p 42RA== X-Gm-Message-State: AOAM533oDNgaSHTdX6D475IVhcuhAPVqkx6SZrb0sDfGlUxOVMBAp6Pa 9jCAHOcMU0fn9F7thPo6Yjp9wJ0MCXQ= X-Google-Smtp-Source: ABdhPJxxvN5alZAb17aOzPofTzpbWNUIMbrANTtoKQjbrQsozneCwu0D+ZP2+ZaHdyYX1ipN/V7O9Q== X-Received: by 2002:a05:6512:31c2:: with SMTP id j2mr2461482lfe.69.1624515465140; Wed, 23 Jun 2021 23:17:45 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id q3sm187146ljp.44.2021.06.23.23.17.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 23:17:44 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 8CCB25A0020; Thu, 24 Jun 2021 09:17:43 +0300 (MSK) Date: Thu, 24 Jun 2021 09:17:43 +0300 To: Alexander Turenko via Tarantool-patches Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH 0/4] RFC: Isolate serializer helpers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: Cyrill Gorcunov , Vladislav Shpilevoy , Alexander Turenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Wed, Jun 23, 2021 at 10:12:38PM +0300, Alexander Turenko via Tarantool-patches wrote: > Moved the serializer helpers into its own compilation unit, add some > comments and a basic test: everything is just to simplify diving into > this code. > > Guys, please, look, whether it seems useful enough to include into > tarantool's mainline? Should we name it serializer.[ch] or > somehow like serializer_helpers.[ch]? > > Part of https://github.com/tarantool/tarantool/issues/3228 > Branch: Totktonada/gh-3228-extract-serializer-helpers The series looks ok from a glance, I'll take more precise look once time permit, but overall idea looks very neat!