From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 148C26E200; Fri, 18 Jun 2021 16:02:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 148C26E200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1624021330; bh=IaRpvo969cTAtOwyZYWQ3i1jF2FfGGApxzncdHuMkPg=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=TnVVyRDE8yjhhCjpahuSLlEUdEdJGrMJhzOutLgJuKRJ9dCAyjC8nRdUWmmYNPQ2N 7S4wWIEFv8E7CqZMZOFmheoJ7ANem5rRU6lfRJpdBwzqXIjnoLH55HXkf0WpiwlFhV VQOW7tOS82aATYRdHDmrMIs1xXUTvbVpnU/PsnCI= Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D32906E200 for ; Fri, 18 Jun 2021 16:02:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D32906E200 Received: by mail-lj1-f170.google.com with SMTP id q23so3458294ljh.0 for ; Fri, 18 Jun 2021 06:02:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5wkzUXJI8bOSHuss0Wdo1JhkIWjmnZwVb4GabDHpFB8=; b=BmTSQlqRJiYONVfdCi186effGg3a0DXQjgC3CXqCoR8B8NK9ZZ8PXePQK90AqdGBWL 5/eqG9Y7bCWShoBHuD6tI8ybGF6DMjvmwQQfhvmQ4JRx9ad09dewVPfAmKFFQtxyoDZe +/AM6mM9hNJAP6mamzFrgaO67jm7ErjvbE8MWQxcUhVdZydvRCh7pMKEaDsn2KVIvL+j PEDW+/7/jSTTpmY4dH6jSN4wVKcWnFS75K4U1+WYZ3+2VhH2htjRWw8Lhci/peSXwBer i828izgJv3cgYC/qxjBFgtB7SaSQsFbIlju+3dy69eL42ampwYeyPJ5IwGNaw79Izss5 0z6w== X-Gm-Message-State: AOAM530w5UsCE8WNsgWb9RWHw7izZEDaEjNDXk4MmJQ1oeJqlCZ5Wbyq U8cL0HEW7EtUXENeCEeP5uPBzQz9Yq8= X-Google-Smtp-Source: ABdhPJx9NqI2Vqo+XaY24jaPL6FodGbXWxbE0WTch+IsiAmEm73c6fif4iQhNM6qhK5TcSdBi4X7Ag== X-Received: by 2002:a2e:9b07:: with SMTP id u7mr9066116lji.209.1624021324396; Fri, 18 Jun 2021 06:02:04 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id n26sm1057166ljj.122.2021.06.18.06.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 06:02:03 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 8A1B55A002A; Fri, 18 Jun 2021 16:02:02 +0300 (MSK) Date: Fri, 18 Jun 2021 16:02:02 +0300 To: Serge Petrenko Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH v2 0/8] forbid implicit limbo ownership transition X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Fri, Jun 18, 2021 at 12:07:34AM +0300, Serge Petrenko wrote: > https://github.com/tarantool/tarantool/issues/5438 > https://github.com/tarantool/tarantool/issues/6034 > https://github.com/tarantool/tarantool/tree/sp/gh-6034-empty-limbo-transition > > Changes in v2: > - reorder the commits for a more logical sequence. > - review fixes as per review from Vlad. > - fix replica_rejoin test > > Serge Petrenko (8): > replication: always send raft state to subscribers > txn_limbo: fix promote term filtering > raft: refactor raft_new_term() > box: make promote always bump the term > replication: forbid implicit limbo owner transition > box: introduce `box.ctl.demote` > txn_limbo: persist the latest effective promote in snapshot > replication: send latest effective promote in initial join The series looks ok to me, thanks! Lets wait for Vlad's review (though i would make fixes on top rather if any)