From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 473696EC55; Fri, 11 Jun 2021 10:53:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 473696EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1623398001; bh=7hCuF8bLr9vGxqo27pVnE6DR7QcWukLDwiJOGRPBjaw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=C6DtwCKfZ7FkVT8rwQ9VlAA6v0usoqJ7/J6Hch0yCuYm8VsRtRPquBa/gd0kyed4U ExZgt9HK61LS35rsoDdTza3Yrw+TNAqucdjw1DdXgT1+dg0EFedPoO8OWm95rpqD92 op6cO1kW8FcRXiKDzXWPPPSZkZ12PSAZgFYYlXiM= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 402916EC55 for ; Fri, 11 Jun 2021 10:53:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 402916EC55 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lrbyh-0003IS-BP; Fri, 11 Jun 2021 10:53:19 +0300 Date: Fri, 11 Jun 2021 10:52:06 +0300 To: Igor Munkin Message-ID: References: <20210602155958.16322-1-skaplun@tarantool.org> <20210610164045.GB3944@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210610164045.GB3944@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D5B0DA836B685C540E30C2BDD69416C6E46C178CD572CB10182A05F5380850404EA2C42756A6F14D019C5C6CB154D3F06C49299951F02404A13D8B6A0C924D83 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73B44982FA5E78411EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FAFFEDEAEB71C4328638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D867FE29F70876BC3A8B168A1110A25B10117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC292D688DDAD4E7BC389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8B861051D4BA689FCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B569F1129A2C6445075ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A593DA4A3BE49E3FA66E7950A3FA6739EBBFDC3B6ABAB8D516D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3433E9BC74ABA5769FD5FEA278ECDC7BA2346791855DA4CCAAD9923FE2B62147864D5050616E4100E91D7E09C32AA3244CE348BCA26F9EAF274A7A17C30464EC6351E887DA02A9F7BFFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojCpYK6nkTlbFhmB6Q8A3KPQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638224FC465DC2DB9A5846E05FD4BE4FDF1C70FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED567EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] build: fix debug flags for LuaJIT assertions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the review! On 10.06.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! Please consider the nits below. Otherwise, LGTM. > > On 02.06.21, Sergey Kaplun wrote: > > This patch fixes inaccuracy in Tarantool build configuration introduced > > by commit 07c83aa ('build: adjust > > Typo: Please use the full hash. > > > LuaJIT build system'). That patch sets LUAJIT_USE_ASSERT and > > LUAJIT_USE_APICHECK options for Debug build instead LUA_USE_ASSERT and > > Typo: s/instead LUA_USE_ASSERT/instead of LUA_USE_ASSERT/. > > > LUA_USE_APICHECK correspondingly. This patch fixes these typos. > > Minor: s/correspondingly/respectively/. Fixed all suggestions, the new commit message is the following: =================================================================== build: fix debug flags for LuaJIT assertions This patch fixes inaccuracy in Tarantool build configuration introduced by commit 07c83aab5c066ca75c149112b331b4dbb81b3f38 ('build: adjust LuaJIT build system'). That patch sets LUAJIT_USE_ASSERT and LUAJIT_USE_APICHECK options for Debug build instead of LUA_USE_ASSERT and LUA_USE_APICHECK respectively. This patch fixes these typos. Follows up #4862 =================================================================== Branch is force-pushed. > > > > > Follows up #4862 > > --- > > > > Branch: https://github.com/tarantool/tarantool/tree/skaplun/tarantool-debug-fix > > > > > > Also, LUAJIT_USE_ASAN -- is set, but LuaJIT checks for ENABLE_ASAN as > > is with corresponding FIXME to implement ASAN correctly. But it > > looks like it should be done in a separate patch by enabling all LuaJIT > > build flags, see list of options here [1]. > > BTW, we have a separate issue for enabling ASAN in LuaJIT[1]. > > > > > [1]: https://lists.tarantool.org/tarantool-patches/20210211192336.GC9361@root/ > > > > cmake/luajit.cmake | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > -- > > 2.31.0 > > > > [1]: https://github.com/tarantool/tarantool/issues/5878 > > -- > Best regards, > IM -- Best regards, Sergey Kaplun