From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 528016EC55; Thu, 10 Jun 2021 19:47:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 528016EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1623343643; bh=mhI8lHseKcXLQkJuwmXR85oce0PMpxYDuah4z2uwx1s=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=H0H2QovMvxLuBUC6C1nWdZDMDQx2yh6BufqT6G1AypxHXjzhnRo9vcWz89/XCu5b9 BF7khDUHJvujpZIiAQzx4Qq6QlTc4a55tinGzj57iuOb45UNe7GsLPutW6i8YPcrCu ELJlL6COhDd9R25N5HS8PcwuGKc2tFNNskHaiVkM= Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2DFF76EC55 for ; Thu, 10 Jun 2021 19:47:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2DFF76EC55 Received: by mail-lf1-f53.google.com with SMTP id v22so4297111lfa.3 for ; Thu, 10 Jun 2021 09:47:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZyAMUBRQ24v7jGoUavdTN+SVeZqMV0aGB6Qr6luEm+0=; b=V8fA1TDeHIMPxivAUVTRHcS8p0+VvIlaXecwtmhWLCsegrpETCMwmzNB81w1Xc8Bld L3B/2KBU7w0aNppdE6LxAYyx4wpFv7YCcVcLbwDygsKB5JeM9YMwFkj/ZLC6/NjixJiA 8nV9zsvX1rUg2+U8TF74FO5I2RqibpQ1w4z7FX9wonJtkC50Xs7t5gtTwx84L/wi5m2X Pe4wWoiZ103+QX67hpXTURVUa0RHRAy5Iu0ymDSg98tplk5ffKRIQk8OKcJRUvVP7Hj3 KYG73ZV9qpGUkLzH0Dkt0o6jldjLoVxw4tZ3lVUeUYu75wSOBUVXr8SWN0xBdefCeq0y AQ4w== X-Gm-Message-State: AOAM533kOYlzGoWNgyKNHIDNwr6TTKBK1/i8MHWDE4xigBm0XjqOtJD/ Pt3X9eaxLS2PiO6T9IXRJwwcSDDlWXw= X-Google-Smtp-Source: ABdhPJyEuyaKkXkfSZkYHRGRCOkAKB8a8ysIJIAET67zMYBDbMUWvTM3UPbMgFH1NeG5t620WR6MjQ== X-Received: by 2002:a19:7b15:: with SMTP id w21mr2571585lfc.162.1623343641016; Thu, 10 Jun 2021 09:47:21 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id x1sm349317lfa.21.2021.06.10.09.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 09:47:19 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id C6D055A0041; Thu, 10 Jun 2021 19:47:18 +0300 (MSK) Date: Thu, 10 Jun 2021 19:47:18 +0300 To: Serge Petrenko Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH 1/7] replication: always send raft state to subscribers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, Jun 10, 2021 at 04:32:51PM +0300, Serge Petrenko wrote: > - if (raft_is_enabled(box_raft())) { > + if (replica_version_id >= version_id(2, 6, 0) && !anon) { > /* > * Send out the current raft state of the instance. Don't do > - * that if Raft is disabled. It can be that a part of the > - * cluster still contains old versions, which can't handle Raft > - * messages. So when it is disabled, its network footprint > - * should be 0. > + * that if the remote instance is old. It can be that a part of > + * the cluster still contains old versions, which can't handle > + * Raft messages. Raft's network footprint should be 0 as seen > + * by such instances. > */ Serge, why can't we send raft state for anon replicas as well? As far as I understand anon replicas do receive raft updates from WAL notifications, right? So this is somehow inconsistent that WAL's based raft updates are reaching anon replicas while initial state from subscribe state is not, or I miss something?